| CARVIEW |
Select Language
HTTP/1.1 302 Found
Server: nginx
Date: Fri, 30 Jan 2026 06:09:36 GMT
Content-Type: text/html; charset=utf-8
Content-Length: 70
Connection: keep-alive
Location: https://github.com/writeas/writefreely/pull/215
HTTP/2 301
date: Fri, 30 Jan 2026 06:09:36 GMT
content-length: 0
location: https://github.com/writefreely/writefreely/pull/215
server-timing: nginx;desc="NGINX";dur=1.117376,glb;desc="GLB";dur=117.315374
x-voltron-version: 69ef6d1
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=AE8rddNEqRb2m3NvDku8Dqpgxt2NHmha5fEVNEJ8X403R5PlAk%2FCLs8F6dw1NObZrmM0yOj8FJsRb%2BSBSRFhK4HpWPd%2BCrEIQ3G0wde8RG7l%2BVyVyIviW5tVVoi6oT3u3o4buN%2BICeSYDJ4jXXSLfDURinq0LuOqINDAu9L0N7ItMXny2TsgnDx6be6XYWGN%2FTtLk1NZZC70rYqMNsJRX%2BJtiALL0rGEF1asbvTamNFc2ysmeMCLjLlzpoCug8Nzm8RDfLyX0b8EkeirxQ5Syg%3D%3D--Xl4Lc7Xu7ZHRk%2BEp--yawG8CLQGGgzk1XfZ3gPjA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.237772101.1769753376; Path=/; Domain=github.com; Expires=Sat, 30 Jan 2027 06:09:36 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 30 Jan 2027 06:09:36 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B4D6:1A4933:480E83:58F3A3:697C4B20
HTTP/2 200
date: Fri, 30 Jan 2026 06:09:37 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=311.722169,conversation_content-fragment;desc="conversation_content fragment";dur=450.526224,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=255.188418,nginx;desc="NGINX";dur=1.356272,glb;desc="GLB";dur=104.708292
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 69ef6d1
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: B4D6:1A4933:480ED2:58F42A:697C4B20
Prevent failed requests on failed user silence check by thebaer · Pull Request #215 · writefreely/writefreely · GitHub
Copy link
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 373
Prevent failed requests on failed user silence check #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also saves a user suspension check when a post isn't found.
Member
Author
|
Actually, previously mentioned issue isn't a regression. We'll need to do some refactoring to fix the issue, but that's out of scope here. Made one more change that prevents an unnecessary log for the user silence check. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This avoids requests completely failing when a user suspension check fails, such as when
IsUserSuspended()indicates that a "user isn't found".There's still some work to do. For example, not-found pages (like
/siteinfo.json) previously showed:Before this fix, they'd show a "Server error" page and a 500.
With this fix, they show:
(and erroneously send two status headers).