| CARVIEW |
Select Language
HTTP/2 301
content-length: 0
location: https://github.com/apache/maven-enforcer/pull/892
HTTP/2 200
date: Fri, 26 Dec 2025 17:31:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=428.794758,conversation_content-fragment;desc="conversation_content fragment";dur=1128.187293,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=304.589894,nginx;desc="NGINX";dur=0.744886,glb;desc="GLB";dur=101.147948
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2B6wjAv3pVGC1hdpho05sCqjroo6ytTpPnTUhNrFSDrZmFzC9v%2FcaA9iygVNLzZhJv4cYbpc%2B7bHor79%2Bdb8ntP80zYzMeyImL373kW6hW9CSkI272palGS5NEoHdHtpDKeVfoNFwlcwr2Z4nf2gDSVrTYuFZocgRwFw0A3Ji2qioECKHXxhoynL9dRpopoiZs%2BOsx1VGJn%2F08LrSrS8VQ%2BaviHwTZiDRqZPrqVeK5DYQ5%2F%2FHz1VyACUas%2B%2B8Le4olHvzgPjUaVaLC85qZMvLmg%3D%3D--9yW%2BsPucyAmyEd4i--EahJs%2FuImcbKwK5tqpKELw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.889586060.1766770286; Path=/; Domain=github.com; Expires=Sat, 26 Dec 2026 17:31:26 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 26 Dec 2026 17:31:26 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E102:3FD896:3B0F36F:46A3BDF:694EC66E
`RequireSameVersions` rule: consider entries in `<plugins>` when analyzing build- and report-plugins by turing85 · Pull Request #892 · apache/maven-enforcer · GitHub
turing85
changed the title
Bugfix/require same versions plugins
Jun 22, 2025
turing85
changed the title
Jun 22, 2025
turing85
force-pushed
the
bugfix/require-same-versions-plugins
branch
from
June 22, 2025 08:37
Copy link
turing85
force-pushed
the
bugfix/require-same-versions-plugins
branch
2 times, most recently
from
June 22, 2025 09:16
Copy link
turing85
force-pushed
the
bugfix/require-same-versions-plugins
branch
from
June 22, 2025 09:30
Copy link
Copy link
Copy link
Copy link
slawekjaranowski
force-pushed
the
bugfix/require-same-versions-plugins
branch
from
June 22, 2025 10:04
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 168
RequireSameVersions rule: consider entries in <plugins> when analyzing build- and report-plugins
#892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
slawekjaranowski
merged 4 commits into
apache:master
from
turing85:bugfix/require-same-versions-plugins
Jun 22, 2025
Merged
RequireSameVersions rule: consider entries in <plugins> when analyzing build- and report-plugins
#892
slawekjaranowski
merged 4 commits into
apache:master
from
turing85:bugfix/require-same-versions-plugins
Jun 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turing85
changed the title
RequireSameVersion plugin: consider entries in <plugins> when analyzing build- and report-plugins
turing85
changed the title
RequireSameVersion plugin: consider entries in <plugins> when analyzing build- and report-pluginsRequireSameVersions rule: consider entries in <plugins> when analyzing build- and report-plugins
turing85
force-pushed
the
bugfix/require-same-versions-plugins
branch
from
f6c7fe3 to
37c85cc
Compare
Contributor
Author
|
@slawekjaranowski I'd like to force-push one more time when the pipeline is green. I introduced the formatting error, and I would like to correct this properly. |
turing85
force-pushed
the
bugfix/require-same-versions-plugins
branch
2 times, most recently
from
f41b292 to
d5a3070
Compare
Contributor
Author
|
@slawekjaranowski Done. I think the PR is ready to be merged now 🙂 |
slawekjaranowski
requested changes
Jun 22, 2025
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireSameVersions.java
Outdated
Show resolved
Hide resolved
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireSameVersions.java
Outdated
Show resolved
Hide resolved
turing85
force-pushed
the
bugfix/require-same-versions-plugins
branch
from
d5a3070 to
fcc96c4
Compare
Member
|
there are also an ITs
we can check it also, and add assertions in |
Member
I will add it |
Contributor
Author
Where exactly are those ITs? I suggest that we create a separate issue for this. |
Member
ITs are in I added simple verification to this PR ... as required this change, and confirms that is ok |
slawekjaranowski
force-pushed
the
bugfix/require-same-versions-plugins
branch
from
3cf611c to
664805c
Compare
slawekjaranowski
approved these changes
Jun 22, 2025
Member
|
@turing85 thanks |
Contributor
Author
You are welcome and thanks for the quick merge 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Resolves #372
RequireSameVersionruleif plugins are analyzed, entries under
<plugins>must be considered fFollowing this checklist to help us incorporate your
contribution quickly and easily: