You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enchance RequireFilesSize rule to be able to enforce size bounds in the entire content of a directory by optionally enabling the new recurscive flag.
The main motivation comes from the target directory that tends to store all kind of information from jar artifacts to test logs, reports, and many other things. It is not uncommon, that small seemingly innocent changes (e.g., adding a new test) can make the target directory unreasonably large consuming many GB of disk space. When such changes sneak into the project there is a high risk of causing CI/CD instability and intermittent failures that may be hard to notice.
Following this checklist to help us incorporate your
contribution quickly and easily:
Your pull request should address just one issue, without pulling in other changes.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
Run mvn verify to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
You have run the integration tests successfully (mvn -Prun-its verify).
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
Enchance RequireFilesSize rule to be able to enforce size bounds in the entire content of a directory by optionally enabling the new recurscive flag.
The main motivation comes from the target directory that tends to store all kind of information from jar artifacts to test logs, reports, and many other things. It is not uncommon, that small seemingly innocent changes (e.g., adding a new test) can make the target directory unreasonably large consuming many GB of disk space. When such changes sneak into the project there is a high risk of causing CI/CD instability and intermittent failures that may be hard to notice.
Closeapache#366
Many thanks for the review @slawekjaranowski ! I addressed your comments and updated the documentation in 6b56ba1. I run mvn site and checked that enforcer-rules/target/site/requireFilesSize.html reflects the changes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enchance RequireFilesSize rule to be able to enforce size bounds in the entire content of a directory by optionally enabling the new recurscive flag.
The main motivation comes from the target directory that tends to store all kind of information from jar artifacts to test logs, reports, and many other things. It is not uncommon, that small seemingly innocent changes (e.g., adding a new test) can make the target directory unreasonably large consuming many GB of disk space. When such changes sneak into the project there is a high risk of causing CI/CD instability and intermittent failures that may be hard to notice.
Close #366
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.