| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 63
Addition: support geolocation emulation #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition: support geolocation emulation #183
Conversation
|
At a high level this looks right to me (i.e. I think it matches the WebDriver API in which you provide either a full set of overrides, or null). |
|
As a general comment, please add the markup to indicate that these changes are "Candidate Additions". See the existing annotations in the spec for examples. |
sadym-chromium
changed the title
sadym-chromium
force-pushed
the
sadym/geolocation-emulation
branch
3 times, most recently
from
e80cc2a to
8fc1684
Compare
sadym-chromium
force-pushed
the
sadym/geolocation-emulation
branch
from
8fc1684 to
d0c2e91
Compare
done |
|
Converting for draft to wait for the webdriver-bidi specification and corresponding WPT tests are landed. |
|
Webdriver-bidi is landed. |
|
In the "implementation commitment" section above, shouldn't we still make sure that browsers are committed to implementing the new WebDriver BiDi commands? |
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
|
This change looks good to me, however we still need to get implementation commitment signals from browser engines. Assuming no engine has already implemented the new WebDriver BiDi commands, please file issues for each engine and update the PR template with links to them. |
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
done |
|
Why is WebKit marked "N/A"? |
I'm not aware of WebKit's commitment of supporting geolocation emulation, so I marked it as N/A. I guess the proper way to signal it is just to unmark the checkbox, which I just did. |
|
Please file an issue against WebKit so we can get signals directly from the team. Or maybe @marcoscaceres can comment here. |
done |
|
The web platform tests have been merged to WPT repo: web-platform-tests/wpt#51896 (comment). |
|
@reillyeon do you think we have any other blockers? |
|
It looks like we have consensus from Blink and Gecko. @marcoscaceres, can you ask someone from WebKit to take a look? I'm comfortable merging this now as a candidate addition given current interest signals. |
SHA: 69cc724 Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Labels
4 participants
Closes #146
The following tasks have been completed:
Implementation commitment (and no objections):
Documentation (new feature):
[ ] Updated implementation reportN/A[ ] Pinged MDNN/A. will be exposed via WebDriver BiDi[ ] Added example to README or specN/A. will be exposed via WebDriver BiDiFor documentation, either create an issue or pull request in MDN's Content repo - providing as much information as you can. PR is prefered.
Preview | Diff