cgen: fix option unwrapping on heap var (#23489)

felipensp · web-flow · commit d23e70f54684 · 2025-01-16T23:04:57.000+02:00
diff --git a/vlib/v/gen/c/cgen.v b/vlib/v/gen/c/cgen.v
@@ -5115,8 +5115,13 @@ fn (mut g Gen) ident(node ast.Ident) {
 								}
 							}
 						}
-						if node.obj.ct_type_var != .smartcast && node.obj.is_unwrapped {
-							g.write('.data')
+						if i == 0 && node.obj.ct_type_var != .smartcast && node.obj.is_unwrapped {
+							dot := if !node.obj.orig_type.is_ptr() && obj_sym.is_heap() {
+								'->'
+							} else {
+								'.'
+							}
+							g.write('${dot}data')
 						}
 						g.write(')')
 					}
diff --git a/vlib/v/tests/options/option_heap_var_test.v b/vlib/v/tests/options/option_heap_var_test.v
@@ -0,0 +1,21 @@
+@[heap]
+struct Foo {
+	a int
+}
+
+struct EdgeService {
+	foo Foo
+}
+
+fn t[S](s S) {
+}
+
+fn test_main() {
+	mut svc := ?EdgeService(EdgeService{})
+	if svc != none {
+		t(svc)
+		assert true
+	} else {
+		assert false
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -5115,8 +5115,13 @@ fn (mut g Gen) ident(node ast.Ident) {`
`5115`	`5115`	`}`
`5116`	`5116`	`}`
`5117`	`5117`	`}`
`5118`		`- if node.obj.ct_type_var != .smartcast && node.obj.is_unwrapped {`
`5119`		`- g.write('.data')`
	`5118`	`+ if i == 0 && node.obj.ct_type_var != .smartcast && node.obj.is_unwrapped {`
	`5119`	`+ dot := if !node.obj.orig_type.is_ptr() && obj_sym.is_heap() {`
	`5120`	`+ '->'`
	`5121`	`+ } else {`
	`5122`	`+ '.'`
	`5123`	`+ }`
	`5124`	`+ g.write('${dot}data')`
`5120`	`5125`	`}`
`5121`	`5126`	`g.write(')')`
`5122`	`5127`	`}`