checker: fix missing check for invalid prefixexpr expression &(&var) (fix #23365) (#23418)

felipensp · web-flow · commit ba9d358d5f17 · 2025-01-09T18:15:05.000+02:00
diff --git a/vlib/v/checker/checker.v b/vlib/v/checker/checker.v
@@ -4679,6 +4679,12 @@ fn (mut c Checker) prefix_expr(mut node ast.PrefixExpr) ast.Type {
 			if node.right.op == .amp {
 				c.error('unexpected `&`, expecting expression', node.right.pos)
 			}
+		} else if mut node.right is ast.ParExpr {
+			if mut node.right.expr is ast.PrefixExpr {
+				if node.right.expr.op == .amp {
+					c.error('cannot take the address of this expression', node.right.pos)
+				}
+			}
 		} else if mut node.right is ast.SelectorExpr {
 			if node.right.expr.is_literal() {
 				c.error('cannot take the address of a literal value', node.pos.extend(node.right.pos))
diff --git a/vlib/v/checker/tests/addr_of_invalid_expr.out b/vlib/v/checker/tests/addr_of_invalid_expr.out
@@ -0,0 +1,6 @@
+vlib/v/checker/tests/addr_of_invalid_expr.vv:3:8: error: cannot take the address of this expression
+    1 | fn main() {
+    2 |     a := 1
+    3 |     _ := &(&a)
+      |           ~~~~
+    4 | }
diff --git a/vlib/v/checker/tests/addr_of_invalid_expr.vv b/vlib/v/checker/tests/addr_of_invalid_expr.vv
@@ -0,0 +1,4 @@
+fn main() {
+	a := 1
+	_ := &(&a)
+}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +fn main() {
 +	a := 1
 +	_ := &(&a)
 +}