checker: in vls mode, make ensure_type_exists return true (#25695)

kbkpbot · web-flow · commit ae212174ab9e · 2025-11-09T19:12:13.000+02:00
diff --git a/vlib/v/checker/checker.v b/vlib/v/checker/checker.v
@@ -5576,7 +5576,7 @@ fn (mut c Checker) ensure_generic_type_specify_type_names(typ ast.Type, pos toke
 fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {
 	if typ == 0 {
 		c.error('unknown type', pos)
-		return false
+		return c.pref.is_vls
 	}
 	c.type_level++
 	defer {
@@ -5585,7 +5585,7 @@ fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {
 	if c.type_level > type_level_cutoff_limit {
 		c.error('checker: too many levels of Checker.ensure_type_exists calls: ${c.type_level}, probably due to a self referencing type',
 			pos)
-		return false
+		return c.pref.is_vls
 	}
 	sym := c.table.sym(typ)
 	if !c.is_builtin_mod && !sym.is_pub && sym.mod != c.mod && sym.mod != 'main' {
@@ -5602,12 +5602,12 @@ fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {
 			if fn_mod != '' && fn_mod != c.mod && fn_info.func.name != '' && !fn_info.is_anon {
 				c.error('function type `${fn_info.func.name}` was declared as private to module `${fn_mod}`, so it can not be used inside module `${c.mod}`',
 					pos)
-				return false
+				return c.pref.is_vls
 			}
 		} else if sym.mod != '' {
 			c.error('${sym.kind} `${sym.name}` was declared as private to module `${sym.mod}`, so it can not be used inside module `${c.mod}`',
 				pos)
-			return false
+			return c.pref.is_vls
 		}
 	}
 	match sym.kind {
@@ -5621,7 +5621,7 @@ fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {
 			if sym.language == .v {
 				c.error(util.new_suggestion(sym.name, c.table.known_type_names()).say('unknown type `${sym.name}`'),
 					pos)
-				return false
+				return c.pref.is_vls
 			} else if sym.language == .c {
 				if !c.pref.translated && !c.file.is_translated {
 					c.warn(util.new_suggestion(sym.name, c.table.known_type_names()).say('unknown type `${sym.name}` (all virtual C types must be defined, this will be an error soon)'),
@@ -5643,44 +5643,44 @@ fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {
 					'unknown type `${sym.name}`.\nDid you mean `f64`?'
 				}
 				c.error(msg, pos)
-				return false
+				return c.pref.is_vls
 			}
 		}
 		.function {
 			fn_info := sym.info as ast.FnType
 			if !c.ensure_type_exists(fn_info.func.return_type, fn_info.func.return_type_pos) {
-				return false
+				return c.pref.is_vls
 			}
 			for param in fn_info.func.params {
 				if !c.ensure_type_exists(param.typ, param.type_pos) {
-					return false
+					return c.pref.is_vls
 				}
 			}
 		}
 		.array {
 			if !c.ensure_type_exists((sym.info as ast.Array).elem_type, pos) {
-				return false
+				return c.pref.is_vls
 			}
 		}
 		.array_fixed {
 			if !c.ensure_type_exists((sym.info as ast.ArrayFixed).elem_type, pos) {
-				return false
+				return c.pref.is_vls
 			}
 		}
 		.map {
 			info := sym.info as ast.Map
 			if !c.ensure_type_exists(info.key_type, pos) {
-				return false
+				return c.pref.is_vls
 			}
 			if !c.ensure_type_exists(info.value_type, pos) {
-				return false
+				return c.pref.is_vls
 			}
 		}
 		.sum_type {
 			info := sym.info as ast.SumType
 			for concrete_typ in info.concrete_types {
 				if !c.ensure_type_exists(concrete_typ, pos) {
-					return false
+					return c.pref.is_vls
 				}
 			}
 		}
@@ -5690,7 +5690,7 @@ fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {
 					...pos
 					col: pos.col + 5
 				}) {
-					return false
+					return c.pref.is_vls
 				}
 			}
 		}
diff --git a/vlib/v/tests/vls/autocomplete_module_test.v b/vlib/v/tests/vls/autocomplete_module_test.v
@@ -135,6 +135,11 @@ const test_data = [
 		cmd:    'v -w -check -json-errors -nocolor -vls-mode -line-info "${text_file}:34:gd^13" ${os.quoted_path(text_file)}'
 		output: '${mod1_text_file}:19:10'
 	},
+	TestData{
+		method: .definition
+		cmd:    'v -w -check -json-errors -nocolor -vls-mode -line-info "${text_file}:39:gd^13" ${os.quoted_path(text_file)}'
+		output: '${mod1_text_file}:50:7'
+	},
 	TestData{
 		method: .did_change
 		cmd:    'v -w -vls-mode -check -json-errors ${os.quoted_path(text_file)}'
@@ -234,6 +239,14 @@ const test_data = [
 "col":2,
 "len":0
 }
+,
+{
+"path":"${json_errors_text_file}",
+"message":"unknown type `main.NotExistStruct`",
+"line_nr":38,
+"col":11,
+"len":0
+}
 ]
 '
 	},
diff --git a/vlib/v/tests/vls/sample_text.vv b/vlib/v/tests/vls/sample_text.vv
@@ -33,3 +33,8 @@ fn main() {
 	s.PublicAlias1_2{}
 	s.public_const1
 }
+
+// ensure we can jump to `public_fn1()` even in `NotExistStruct` method
+fn (mut x NotExistStruct) add(val int) {
+	s.public_fn1(1)
+}

Original file line number	Diff line number	Diff line change
`@@ -5576,7 +5576,7 @@ fn (mut c Checker) ensure_generic_type_specify_type_names(typ ast.Type, pos toke`
`5576`	`5576`	`fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {`
`5577`	`5577`	`if typ == 0 {`
`5578`	`5578`	`c.error('unknown type', pos)`
`5579`		`- return false`
	`5579`	`+ return c.pref.is_vls`
`5580`	`5580`	`}`
`5581`	`5581`	`c.type_level++`
`5582`	`5582`	`defer {`
`@@ -5585,7 +5585,7 @@ fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {`
`5585`	`5585`	`if c.type_level > type_level_cutoff_limit {`
`5586`	`5586`	`c.error('checker: too many levels of Checker.ensure_type_exists calls: ${c.type_level}, probably due to a self referencing type',`
`5587`	`5587`	`pos)`
`5588`		`- return false`
	`5588`	`+ return c.pref.is_vls`
`5589`	`5589`	`}`
`5590`	`5590`	`sym := c.table.sym(typ)`
`5591`	`5591`	`if !c.is_builtin_mod && !sym.is_pub && sym.mod != c.mod && sym.mod != 'main' {`
`@@ -5602,12 +5602,12 @@ fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {`
`5602`	`5602`	`if fn_mod != '' && fn_mod != c.mod && fn_info.func.name != '' && !fn_info.is_anon {`
`5603`	`5603`	c.error('function type `${fn_info.func.name}` was declared as private to module `${fn_mod}`, so it can not be used inside module `${c.mod}`',
`5604`	`5604`	`pos)`
`5605`		`- return false`
	`5605`	`+ return c.pref.is_vls`
`5606`	`5606`	`}`
`5607`	`5607`	`} else if sym.mod != '' {`
`5608`	`5608`	c.error('${sym.kind} `${sym.name}` was declared as private to module `${sym.mod}`, so it can not be used inside module `${c.mod}`',
`5609`	`5609`	`pos)`
`5610`		`- return false`
	`5610`	`+ return c.pref.is_vls`
`5611`	`5611`	`}`
`5612`	`5612`	`}`
`5613`	`5613`	`match sym.kind {`
`@@ -5621,7 +5621,7 @@ fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {`
`5621`	`5621`	`if sym.language == .v {`
`5622`	`5622`	c.error(util.new_suggestion(sym.name, c.table.known_type_names()).say('unknown type `${sym.name}`'),
`5623`	`5623`	`pos)`
`5624`		`- return false`
	`5624`	`+ return c.pref.is_vls`
`5625`	`5625`	`} else if sym.language == .c {`
`5626`	`5626`	`if !c.pref.translated && !c.file.is_translated {`
`5627`	`5627`	c.warn(util.new_suggestion(sym.name, c.table.known_type_names()).say('unknown type `${sym.name}` (all virtual C types must be defined, this will be an error soon)'),
`@@ -5643,44 +5643,44 @@ fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {`
`5643`	`5643`	'unknown type `${sym.name}`.\nDid you mean `f64`?'
`5644`	`5644`	`}`
`5645`	`5645`	`c.error(msg, pos)`
`5646`		`- return false`
	`5646`	`+ return c.pref.is_vls`
`5647`	`5647`	`}`
`5648`	`5648`	`}`
`5649`	`5649`	`.function {`
`5650`	`5650`	`fn_info := sym.info as ast.FnType`
`5651`	`5651`	`if !c.ensure_type_exists(fn_info.func.return_type, fn_info.func.return_type_pos) {`
`5652`		`- return false`
	`5652`	`+ return c.pref.is_vls`
`5653`	`5653`	`}`
`5654`	`5654`	`for param in fn_info.func.params {`
`5655`	`5655`	`if !c.ensure_type_exists(param.typ, param.type_pos) {`
`5656`		`- return false`
	`5656`	`+ return c.pref.is_vls`
`5657`	`5657`	`}`
`5658`	`5658`	`}`
`5659`	`5659`	`}`
`5660`	`5660`	`.array {`
`5661`	`5661`	`if !c.ensure_type_exists((sym.info as ast.Array).elem_type, pos) {`
`5662`		`- return false`
	`5662`	`+ return c.pref.is_vls`
`5663`	`5663`	`}`
`5664`	`5664`	`}`
`5665`	`5665`	`.array_fixed {`
`5666`	`5666`	`if !c.ensure_type_exists((sym.info as ast.ArrayFixed).elem_type, pos) {`
`5667`		`- return false`
	`5667`	`+ return c.pref.is_vls`
`5668`	`5668`	`}`
`5669`	`5669`	`}`
`5670`	`5670`	`.map {`
`5671`	`5671`	`info := sym.info as ast.Map`
`5672`	`5672`	`if !c.ensure_type_exists(info.key_type, pos) {`
`5673`		`- return false`
	`5673`	`+ return c.pref.is_vls`
`5674`	`5674`	`}`
`5675`	`5675`	`if !c.ensure_type_exists(info.value_type, pos) {`
`5676`		`- return false`
	`5676`	`+ return c.pref.is_vls`
`5677`	`5677`	`}`
`5678`	`5678`	`}`
`5679`	`5679`	`.sum_type {`
`5680`	`5680`	`info := sym.info as ast.SumType`
`5681`	`5681`	`for concrete_typ in info.concrete_types {`
`5682`	`5682`	`if !c.ensure_type_exists(concrete_typ, pos) {`
`5683`		`- return false`
	`5683`	`+ return c.pref.is_vls`
`5684`	`5684`	`}`
`5685`	`5685`	`}`
`5686`	`5686`	`}`
`@@ -5690,7 +5690,7 @@ fn (mut c Checker) ensure_type_exists(typ ast.Type, pos token.Pos) bool {`
`5690`	`5690`	`...pos`
`5691`	`5691`	`col: pos.col + 5`
`5692`	`5692`	`}) {`
`5693`		`- return false`
	`5693`	`+ return c.pref.is_vls`
`5694`	`5694`	`}`
`5695`	`5695`	`}`
`5696`	`5696`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,3 +33,8 @@ fn main() {`
`33`	`33`	`s.PublicAlias1_2{}`
`34`	`34`	`s.public_const1`
`35`	`35`	`}`
	`36`	`+`
	`37`	+// ensure we can jump to `public_fn1()` even in `NotExistStruct` method
	`38`	`+fn (mut x NotExistStruct) add(val int) {`
	`39`	`+ s.public_fn1(1)`
	`40`	`+}`