builtin: use s.runes_iterator() in trim_runes/2 to avoid needless allocation

spytheman · spytheman · commit 96c32ecd1900 · 2025-06-23T23:08:18.000+03:00
diff --git a/vlib/builtin/string.v b/vlib/builtin/string.v
@@ -1877,14 +1877,13 @@ fn (s string) trim_chars(cutset string, mode TrimMode) string {
 @[direct_array_access]
 fn (s string) trim_runes(cutset string, mode TrimMode) string {
 	s_runes := s.runes()
-	c_runes := cutset.runes()
 	mut pos_left := 0
 	mut pos_right := s_runes.len - 1
 	mut cs_match := true
 	for pos_left <= s_runes.len && pos_right >= -1 && cs_match {
 		cs_match = false
 		if mode in [.trim_left, .trim_both] {
-			for cs in c_runes {
+			for cs in cutset.runes_iterator() {
 				if s_runes[pos_left] == cs {
 					pos_left++
 					cs_match = true
@@ -1893,7 +1892,7 @@ fn (s string) trim_runes(cutset string, mode TrimMode) string {
 			}
 		}
 		if mode in [.trim_right, .trim_both] {
-			for cs in c_runes {
+			for cs in cutset.runes_iterator() {
 				if s_runes[pos_right] == cs {
 					pos_right--
 					cs_match = true
