checker: fix generic resolve for external module generic static method call (fix #21476) (#25634)

felipensp · web-flow · commit 706179fb7458 · 2025-10-31T19:08:20.000+02:00
diff --git a/vlib/v/checker/fn.v b/vlib/v/checker/fn.v
@@ -1157,6 +1157,9 @@ fn (mut c Checker) fn_call(mut node ast.CallExpr, mut continue_check &bool) ast.
 					func = f
 					node.name = qualified_name
 					unsafe { c.table.fns[qualified_name].usages++ }
+					if !c.table.register_fn_concrete_types(f.name, concrete_types) {
+						c.need_recheck_generic_fns = true
+					}
 					break
 				}
 			}
diff --git a/vlib/v/tests/project_issue_21476/foo.v b/vlib/v/tests/project_issue_21476/foo.v
@@ -0,0 +1,7 @@
+module zmod_foo
+
+pub struct Foo[T] {}
+
+pub fn Foo.new[T](embed T) &Foo[T] {
+	return &Foo[T]{}
+}
diff --git a/vlib/v/tests/project_issue_21476/main.v b/vlib/v/tests/project_issue_21476/main.v
@@ -0,0 +1,12 @@
+module main
+
+import zmod_foo { Foo }
+
+struct Bar {}
+
+fn main() {
+	// note: will succeed with foo.Foo
+	f := Foo.new[Bar](Bar{})
+
+	println(typeof(f).name)
+}
diff --git a/vlib/v/tests/project_issue_21476/project_compiles_test.v b/vlib/v/tests/project_issue_21476/project_compiles_test.v
@@ -0,0 +1,5 @@
+module main
+
+fn test_compiles() {
+	assert true
+}
diff --git a/vlib/v/tests/project_issue_21476/v.mod b/vlib/v/tests/project_issue_21476/v.mod

Original file line number	Diff line number	Diff line change
`@@ -1157,6 +1157,9 @@ fn (mut c Checker) fn_call(mut node ast.CallExpr, mut continue_check &bool) ast.`
`1157`	`1157`	`func = f`
`1158`	`1158`	`node.name = qualified_name`
`1159`	`1159`	`unsafe { c.table.fns[qualified_name].usages++ }`
	`1160`	`+ if !c.table.register_fn_concrete_types(f.name, concrete_types) {`
	`1161`	`+ c.need_recheck_generic_fns = true`
	`1162`	`+ }`
`1160`	`1163`	`break`
`1161`	`1164`	`}`
`1162`	`1165`	`}`