ci: make easier the debugging of the docker-alpine-musl-gcc job (#23399)

spytheman · web-flow · commit 63db71b650a4 · 2025-01-07T15:19:59.000+02:00
diff --git a/.github/workflows/Dockerfile.ci_alpine_local b/.github/workflows/Dockerfile.ci_alpine_local
@@ -0,0 +1,52 @@
+#######################################################################################
+## The goal of this file, is to provide an easy and reproducible way to check *locally*
+## the CI job `docker-alpine-musl-gcc`
+## Building the docker image:
+##    docker build -t ci_alpine_local - < .github/workflows/Dockerfile.ci_alpine_local
+## Running the docker image, after building it:
+##    docker run --rm -it -v .:/opt/vlang -w /opt/vlang ci_alpine_local
+## Once it is running, inside the container you can:
+##    make && v -e 'println(2+2)'
+## ... then do whatever you need to reproduce the CI test failure.
+## Note: after you are finished, and exit the container, run `make` again, otherwise 
+## you will be using V (and potentially V tools) that were compiled with musl.
+#######################################################################################
+FROM thevlang/vlang:alpine-build
+
+LABEL maintainer="spytheman <spytheman@bulsynt.org>"
+
+WORKDIR /opt/vlang
+
+ENV PATH /opt/vlang:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+
+## install development packages
+RUN apk --no-cache add \
+  musl-dev libc-dev libc6-compat gcompat \
+  libunwind-dev libunwind-static \
+  gc gc-dev \
+  binutils diffutils elfutils \
+  strace gdb \
+  pcre bash fzf fzf-vim tmux less file colordiff \
+  vim vim-editorconfig \
+  nano nano-syntax \
+  micro
+
+RUN git config --global --add safe.directory /opt/vlang &&\
+    git config --global --add safe.directory /opt/vlang/vc &&\
+    git config --global --add safe.directory /opt/vlang/thirdparty/tcc &&\
+    find /usr/share/nano/ -iname "*.nanorc" -exec echo include {} \; >> ~/.nanorc &&\
+    micro -plugin install detectindent &&\
+    micro -plugin install editorconfig &&\
+    micro -plugin install monokai-dark &&\
+    micro -plugin install quickfix &&\
+    micro -plugin install runit &&\
+    micro -plugin install cheat &&\
+    micro -plugin install jump &&\
+    true
+
+## setup runtime environment for v and bash:
+ENV VTMP     /tmp/v
+ENV VMODULES /tmp/vmodules
+ENV VFLAGS  "-d dynamic_boehm"
+
+CMD ["bash"]
diff --git a/.github/workflows/docker_ci.yml b/.github/workflows/docker_ci.yml
@@ -24,7 +24,7 @@ env:
   V_CI_MUSL: 1
 
 jobs:
-  alpine-docker-musl-gcc:
+  docker-alpine-musl-gcc:
     runs-on: ubuntu-20.04
     timeout-minutes: 241
     container:
@@ -45,15 +45,15 @@ jobs:
           echo "C Compiler:"
           gcc --version
       - name: Add dependencies
-        run: apk add libc6-compat
+        run: apk add libc6-compat gcompat gc gc-dev binutils diffutils elfutils
       - name: Build V
         run: CC=gcc make
       - name: All code is formatted
         run: VJOBS=1 ./v test-cleancode
       - name: Run only essential tests
         run: VTEST_JUST_ESSENTIAL=1 ./v test-self
 
-  ubuntu-docker-musl:
+  docker-ubuntu-musl:
     runs-on: ubuntu-20.04
     timeout-minutes: 121
     container:
diff --git a/.github/workflows/tools_ci.yml b/.github/workflows/tools_ci.yml
@@ -101,7 +101,7 @@ jobs:
         if: ${{ matrix.cc == 'msvc' }}
         run: ./v -W -cstrict test-self cmd
 
-  ubuntu-docker-musl:
+  tools-docker-ubuntu-musl:
     runs-on: ubuntu-20.04
     timeout-minutes: 121
     container:
diff --git a/cmd/tools/modules/testing/common.v b/cmd/tools/modules/testing/common.v
@@ -278,7 +278,7 @@ pub fn new_test_session(_vargs string, will_compile bool) TestSession {
 		$if !macos {
 			skip_files << 'examples/macos_tray/tray.v'
 		}
-		if github_job == 'ubuntu-docker-musl' {
+		if github_job == 'docker-ubuntu-musl' {
 			skip_files << 'vlib/net/openssl/openssl_compiles_test.c.v'
 			skip_files << 'vlib/crypto/ecdsa/ecdsa_test.v'
 			skip_files << 'vlib/x/ttf/ttf_test.v'
diff --git a/vlib/v/gen/golang/tests/golang_test.v b/vlib/v/gen/golang/tests/golang_test.v
@@ -9,7 +9,7 @@ const is_verbose = os.getenv('VTEST_SHOW_CMD') != ''
 // TODO: some logic copy pasted from valgrind_test.v and compiler_test.v, move to a module
 fn test_golang() {
 	// this was failing on ubuntu-docker-musl, skip it for now
-	if github_job == 'ubuntu-docker-musl' {
+	if github_job in ['docker-ubuntu-musl', 'tools-docker-ubuntu-musl'] {
 		eprintln('Skipping Go tests')
 		exit(0)
 	}

Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,7 @@ pub fn new_test_session(_vargs string, will_compile bool) TestSession {`
`278`	`278`	`$if !macos {`
`279`	`279`	`skip_files << 'examples/macos_tray/tray.v'`
`280`	`280`	`}`
`281`		`- if github_job == 'ubuntu-docker-musl' {`
	`281`	`+ if github_job == 'docker-ubuntu-musl' {`
`282`	`282`	`skip_files << 'vlib/net/openssl/openssl_compiles_test.c.v'`
`283`	`283`	`skip_files << 'vlib/crypto/ecdsa/ecdsa_test.v'`
`284`	`284`	`skip_files << 'vlib/x/ttf/ttf_test.v'`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ const is_verbose = os.getenv('VTEST_SHOW_CMD') != ''`
`9`	`9`	`// TODO: some logic copy pasted from valgrind_test.v and compiler_test.v, move to a module`
`10`	`10`	`fn test_golang() {`
`11`	`11`	`// this was failing on ubuntu-docker-musl, skip it for now`
`12`		`- if github_job == 'ubuntu-docker-musl' {`
	`12`	`+ if github_job in ['docker-ubuntu-musl', 'tools-docker-ubuntu-musl'] {`
`13`	`13`	`eprintln('Skipping Go tests')`
`14`	`14`	`exit(0)`
`15`	`15`	`}`