refactor: simplify error handling in dotenv loading

vinhnx · vinhnx · commit fa46b86c5df6 · 2025-12-25T22:07:32.000+07:00
diff --git a/src/agent/runloop/unified/diagnostics.rs b/src/agent/runloop/unified/diagnostics.rs
@@ -125,14 +125,11 @@ pub(crate) async fn run_doctor_diagnostics(
         render_doctor_check(
             renderer,
             "  HITL Enabled",
-            Ok(format!(
-                "{}",
-                if cfg.security.human_in_the_loop {
+            Ok((if cfg.security.human_in_the_loop {
                     "Yes"
                 } else {
                     "No"
-                }
-            )),
+                }).to_string()),
         )?;
 
         // Tool default policy
@@ -147,7 +144,7 @@ pub(crate) async fn run_doctor_diagnostics(
         render_doctor_check(
             renderer,
             "  PTY Enabled",
-            Ok(format!("{}", if cfg.pty.enabled { "Yes" } else { "No" })),
+            Ok((if cfg.pty.enabled { "Yes" } else { "No" }).to_string()),
         )?;
     }
 
diff --git a/src/main.rs b/src/main.rs
@@ -57,11 +57,10 @@ async fn run() -> Result<()> {
     panic_hook::set_debug_mode(args.debug);
 
     // Load .env (non-fatal if missing)
-    if let Err(err) = load_dotenv() {
-        if !args.quiet {
+    if let Err(err) = load_dotenv()
+        && !args.quiet {
             eprintln!("vtcode: warning: failed to load .env: {err}");
         }
-    }
 
     process_hardening::apply_process_hardening()
         .context("failed to apply process hardening safeguards")?;
