feat: improve error handling for create_file and update_plan methods, enhance logging for theme loading failures

vinhnx · vinhnx · commit 297886387d17 · 2025-12-25T16:47:06.000+07:00
diff --git a/docs/project/TODO.md b/docs/project/TODO.md
@@ -6,6 +6,10 @@ add support for custom session IDs when forking sessions with --session-id combi
 
 --
 
+agent skills execution performance is too slow when using tools with filesystem (create/edit files), improve performance when executing skills
+
+--
+
 implement input history cycling with up/down arrow keys in the terminal input box
 
 --
diff --git a/vtcode-core/src/tools/file_ops.rs b/vtcode-core/src/tools/file_ops.rs
@@ -1035,9 +1035,12 @@ impl FileOpsTool {
 
     /// Create a brand-new file, returning an error if the target already exists.
     pub async fn create_file(&self, args: Value) -> Result<Value> {
-        let input: CreateInput = serde_json::from_value(args).context(
-            "Error: Invalid 'create_file' arguments. Expected JSON object with: path (required, string), content (required, string). Example: {\"path\": \"src/lib.rs\", \"content\": \"fn main() {}\\n\"}",
-        )?;
+        let input: CreateInput = serde_json::from_value(args.clone()).map_err(|error| {
+            anyhow!(
+                "Error: Invalid 'create_file' arguments. Provide an object like {{\"path\": \"src/lib.rs\", \"content\": \"fn main() {{}}\\n\"}} with optional \"encoding\". Deserialization failed: {}",
+                error
+            )
+        })?;
 
         let CreateInput {
             path,
diff --git a/vtcode-core/src/tools/registry/executors.rs b/vtcode-core/src/tools/registry/executors.rs
@@ -1055,8 +1055,18 @@ impl ToolRegistry {
     pub(super) fn update_plan_executor(&mut self, args: Value) -> BoxFuture<'_, Result<Value>> {
         let manager = self.inventory.plan_manager();
         Box::pin(async move {
-            let parsed: UpdatePlanArgs = serde_json::from_value(args)
-                .context("update_plan requires plan items with step and status")?;
+            let parsed: UpdatePlanArgs = serde_json::from_value(args.clone()).map_err(|error| {
+                anyhow!(
+                    "Error: Invalid 'update_plan' arguments. Provide an object like {{\"plan\": [\"step one\", {{\"step\": \"step two\", \"status\": \"in_progress\"}}], \"explanation\": \"optional focus\", \"phase\": \"understanding|design|review|final_plan\"}}. Deserialization failed: {}",
+                    error
+                )
+            })?;
+
+            if parsed.plan.is_empty() {
+                return Err(anyhow!(
+                    "Error: 'plan' must include at least one step. Example: {{\"plan\": [\"draft outline\", {{\"step\": \"implement fix\", \"status\": \"in_progress\"}}]}}"
+                ));
+            }
             let updated_plan = manager
                 .update_plan(parsed)
                 .context("failed to update plan state")?;
diff --git a/vtcode-core/src/ui/markdown.rs b/vtcode-core/src/ui/markdown.rs
@@ -165,7 +165,9 @@ static THEME_CACHE: Lazy<parking_lot::RwLock<HashMap<String, Theme>>> = Lazy::ne
         }
         _ => {
             // If theme loading fails, create empty cache and log warning
-            warn!("Failed to load default syntax highlighting themes; syntax highlighting will be disabled");
+            warn!(
+                "Failed to load default syntax highlighting themes; syntax highlighting will be disabled"
+            );
             parking_lot::RwLock::new(HashMap::new())
         }
     }
diff --git a/vtcode-core/src/ui/tui/log.rs b/vtcode-core/src/ui/tui/log.rs
@@ -9,8 +9,8 @@ use ratatui::{
     text::{Line, Span, Text},
 };
 use tokio::sync::mpsc::UnboundedSender;
-use tracing::{Event, Level, Subscriber, field::Visit};
 use tracing::warn;
+use tracing::{Event, Level, Subscriber, field::Visit};
 use tracing_subscriber::layer::{Context, Layer};
 use tracing_subscriber::registry::LookupSpan;
 use tui_syntax_highlight::{
@@ -62,13 +62,11 @@ static LOG_SYNTAX_SET: Lazy<SyntaxSet> = Lazy::new(|| {
     }
     syntax_set
 });
-static LOG_THEME_SET: Lazy<ThemeSet> = Lazy::new(|| {
-    match ThemeSet::load_defaults() {
-        theme_set if !theme_set.themes.is_empty() => theme_set,
-        _ => {
-            warn!("Failed to load theme set for log highlighting; using empty theme set");
-            ThemeSet::new()
-        }
+static LOG_THEME_SET: Lazy<ThemeSet> = Lazy::new(|| match ThemeSet::load_defaults() {
+    theme_set if !theme_set.themes.is_empty() => theme_set,
+    _ => {
+        warn!("Failed to load theme set for log highlighting; using empty theme set");
+        ThemeSet::new()
     }
 });
 static LOG_THEME_NAME: Lazy<RwLock<Option<String>>> = Lazy::new(|| RwLock::new(None));
@@ -202,13 +200,13 @@ pub fn set_log_theme_name(theme: Option<String>) {
 
 fn resolve_theme(theme_name: Option<String>) -> Theme {
     let name = theme_name.unwrap_or_else(|| DEFAULT_THEME_NAME.to_string());
-    
+
     // If themes are empty, return default theme early
     if LOG_THEME_SET.themes.is_empty() {
         warn!("No log highlighting themes available");
         return Theme::default();
     }
-    
+
     if let Some(theme) = LOG_THEME_SET.themes.get(&name) {
         return theme.clone();
     }
@@ -319,7 +317,7 @@ pub fn highlight_log_entry(entry: &LogEntry) -> Text<'static> {
         prepend_metadata(&mut text, entry);
         return text;
     }
-    
+
     let syntax = select_syntax(entry.message.as_ref());
     let mut highlighted = highlighter_for_current_theme()
         .highlight_lines(entry.message.lines(), syntax, &LOG_SYNTAX_SET)

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,9 @@ static THEME_CACHE: Lazy<parking_lot::RwLock<HashMap<String, Theme>>> = Lazy::ne`
`165`	`165`	`}`
`166`	`166`	`_ => {`
`167`	`167`	`// If theme loading fails, create empty cache and log warning`
`168`		`- warn!("Failed to load default syntax highlighting themes; syntax highlighting will be disabled");`
	`168`	`+ warn!(`
	`169`	`+ "Failed to load default syntax highlighting themes; syntax highlighting will be disabled"`
	`170`	`+ );`
`169`	`171`	`parking_lot::RwLock::new(HashMap::new())`
`170`	`172`	`}`
`171`	`173`	`}`