refactor: apply clippy fixes for code quality improvements

vinhnx · vinhnx · commit 07dec14bfe3c · 2025-12-23T15:25:51.000+07:00
diff --git a/vtcode-core/src/llm/provider.rs b/vtcode-core/src/llm/provider.rs
@@ -57,6 +57,7 @@ use crate::config::types::{ReasoningEffortLevel, VerbosityLevel};
 
 /// Universal LLM request structure
 #[derive(Debug, Clone, Serialize, Deserialize)]
+#[derive(Default)]
 pub struct LLMRequest {
     pub messages: Vec<Message>,
     pub system_prompt: Option<String>,
@@ -96,39 +97,17 @@ pub struct LLMRequest {
     pub stop_sequences: Option<Vec<String>>,
 }
 
-impl Default for LLMRequest {
-    fn default() -> Self {
-        Self {
-            messages: Vec::new(),
-            system_prompt: None,
-            tools: None,
-            model: String::new(),
-            max_tokens: None,
-            temperature: None,
-            stream: false,
-            output_format: None,
-            tool_choice: None, // Default to None, allowing provider to decide or be explicitly set
-            parallel_tool_calls: None, // Default to None, allowing provider to decide or be explicitly set
-            parallel_tool_config: None,
-            reasoning_effort: None,
-            verbosity: None,
-            top_p: None,
-            top_k: None,
-            presence_penalty: None,
-            frequency_penalty: None,
-            stop_sequences: None,
-        }
-    }
-}
 
 /// Tool choice configuration that works across different providers
 /// Based on OpenAI, Anthropic, and Gemini API specifications
 /// Follows Anthropic's tool use best practices for optimal performance
 #[derive(Debug, Clone, Serialize, Deserialize)]
 #[serde(untagged)]
+#[derive(Default)]
 pub enum ToolChoice {
     /// Let the model decide whether to call tools ("auto")
     /// Default behavior - allows model to use tools when appropriate
+    #[default]
     Auto,
 
     /// Force the model to not call any tools ("none")
@@ -144,11 +123,6 @@ pub enum ToolChoice {
     Specific(SpecificToolChoice),
 }
 
-impl Default for ToolChoice {
-    fn default() -> Self {
-        Self::Auto
-    }
-}
 
 /// Specific tool choice for forcing a particular function call
 #[derive(Debug, Clone, Serialize, Deserialize)]
@@ -361,6 +335,7 @@ impl ContentPart {
 
 /// Universal message structure supporting both text and image content
 #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
+#[derive(Default)]
 pub struct Message {
     #[serde(default)]
     pub role: MessageRole,
@@ -381,19 +356,6 @@ pub struct Message {
     pub origin_tool: Option<String>,
 }
 
-impl Default for Message {
-    fn default() -> Self {
-        Self {
-            role: MessageRole::default(),
-            content: MessageContent::default(),
-            reasoning: None,
-            reasoning_details: None,
-            tool_calls: None,
-            tool_call_id: None,
-            origin_tool: None,
-        }
-    }
-}
 
 #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
 #[serde(untagged)]
diff --git a/vtcode-core/src/tools/plan.rs b/vtcode-core/src/tools/plan.rs
@@ -367,11 +367,10 @@ fn render_plan_markdown(plan: &TaskPlan) -> String {
         );
     }
 
-    if let Some(explanation) = &plan.explanation {
-        if !explanation.is_empty() {
+    if let Some(explanation) = &plan.explanation
+        && !explanation.is_empty() {
             let _ = writeln!(output, "\nFocus: {}", explanation);
         }
-    }
 
     let _ = writeln!(output, "\n## Steps");
     for (idx, step) in plan.steps.iter().enumerate() {
diff --git a/vtcode-core/src/tools/registry/mod.rs b/vtcode-core/src/tools/registry/mod.rs
@@ -2518,9 +2518,7 @@ impl ToolRegistry {
 }
 
 fn planning_allowed(name: &str) -> bool {
-    PLANNING_ALLOWED_TOOLS
-        .iter()
-        .any(|allowed| *allowed == name)
+    PLANNING_ALLOWED_TOOLS.contains(&name)
 }
 
 impl ToolRegistry {
diff --git a/vtcode-core/src/tools/registry/progressive_docs.rs b/vtcode-core/src/tools/registry/progressive_docs.rs
@@ -35,6 +35,7 @@ use std::collections::HashMap;
 /// Documentation mode for tools
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
 #[serde(rename_all = "lowercase")]
+#[derive(Default)]
 pub enum ToolDocumentationMode {
     /// Minimal signatures only (~800 tokens total)
     /// Best for: Power users, token-constrained contexts
@@ -46,14 +47,10 @@ pub enum ToolDocumentationMode {
 
     /// Full documentation upfront (~3,000 tokens total)
     /// Best for: Maximum hand-holding, current behavior
+    #[default]
     Full,
 }
 
-impl Default for ToolDocumentationMode {
-    fn default() -> Self {
-        Self::Full // Backward compatibility - current behavior
-    }
-}
 
 impl ToolDocumentationMode {
     pub fn as_str(self) -> &'static str {
diff --git a/vtcode-core/src/tools/result.rs b/vtcode-core/src/tools/result.rs
@@ -96,11 +96,7 @@ impl ToolResult {
 
         let llm_tokens = estimate_tokens(&llm_str);
         let ui_tokens = estimate_tokens(&ui_str);
-        let savings = if ui_tokens > llm_tokens {
-            ui_tokens - llm_tokens
-        } else {
-            0
-        };
+        let savings = ui_tokens.saturating_sub(llm_tokens);
         let savings_pct = if ui_tokens > 0 {
             (savings as f32 / ui_tokens as f32) * 100.0
         } else {
diff --git a/vtcode-core/src/tools/summarizers/file_ops.rs b/vtcode-core/src/tools/summarizers/file_ops.rs
@@ -135,7 +135,7 @@ impl Summarizer for EditSummarizer {
                 .take(5)
                 .map(|f| {
                     // Extract just filename from path
-                    f.split('/').last().unwrap_or(f)
+                    f.split('/').next_back().unwrap_or(f)
                 })
                 .collect::<Vec<_>>()
                 .join(", ");
diff --git a/vtcode-core/src/tools/summarizers/mod.rs b/vtcode-core/src/tools/summarizers/mod.rs
@@ -38,11 +38,7 @@ pub trait Summarizer {
     fn estimate_savings(&self, full_output: &str, summary: &str) -> (usize, usize, f32) {
         let ui_tokens = estimate_tokens(full_output);
         let llm_tokens = estimate_tokens(summary);
-        let savings = if ui_tokens > llm_tokens {
-            ui_tokens - llm_tokens
-        } else {
-            0
-        };
+        let savings = ui_tokens.saturating_sub(llm_tokens);
         let savings_pct = if ui_tokens > 0 {
             (savings as f32 / ui_tokens as f32) * 100.0
         } else {
diff --git a/vtcode-core/src/tools/summarizers/search.rs b/vtcode-core/src/tools/summarizers/search.rs
@@ -197,11 +197,10 @@ fn parse_list_output(output: &str) -> ListStats {
         } else {
             stats.file_count += 1;
             // Extract simple filename
-            if let Some(name) = line.split('/').last() {
-                if name.len() > 0 && name.len() < 50 {
+            if let Some(name) = line.split('/').next_back()
+                && !name.is_empty() && name.len() < 50 {
                     stats.sample_files.push(name.to_string());
                 }
-            }
         }
     }
 
@@ -225,11 +224,10 @@ fn extract_symbols(line: &str, symbols: &mut std::collections::HashSet<String>)
     for keyword in &["struct ", "impl ", "trait ", "enum "] {
         if let Some(pos) = line.find(keyword) {
             let after_kw = &line[pos + keyword.len()..];
-            if let Some(first_word) = after_kw.split_whitespace().next() {
-                if first_word.len() < 30 && !first_word.contains('{') {
+            if let Some(first_word) = after_kw.split_whitespace().next()
+                && first_word.len() < 30 && !first_word.contains('{') {
                     symbols.insert(first_word.to_string());
                 }
-            }
         }
     }
 }
diff --git a/vtcode-core/src/ui/tui/session.rs b/vtcode-core/src/ui/tui/session.rs
@@ -599,7 +599,7 @@ impl Session {
         self.show_timeline_pane = config.ui.show_timeline_pane;
 
         // Apply theme changes in real-time
-        if let Ok(_) = crate::ui::theme::set_active_theme(&config.agent.theme) {
+        if crate::ui::theme::set_active_theme(&config.agent.theme).is_ok() {
             let active_styles = crate::ui::theme::active_styles();
             let inline_theme = crate::ui::tui::style::theme_from_styles(&active_styles);
 
diff --git a/vtcode-core/src/ui/tui/session/config_palette.rs b/vtcode-core/src/ui/tui/session/config_palette.rs
@@ -371,8 +371,8 @@ impl ConfigPalette {
     }
 
     pub fn adjust_numeric_val(&mut self, delta: i64) {
-        if let Some(index) = self.selected() {
-            if let Some(item) = self.items.get(index) {
+        if let Some(index) = self.selected()
+            && let Some(item) = self.items.get(index) {
                 let key = item.key.clone();
                 let mut changed = false;
 
@@ -430,12 +430,11 @@ impl ConfigPalette {
                     self.reload_items_from_config();
                 }
             }
-        }
     }
 
     pub fn toggle_selected(&mut self) {
-        if let Some(index) = self.selected() {
-            if let Some(item) = self.items.get(index) {
+        if let Some(index) = self.selected()
+            && let Some(item) = self.items.get(index) {
                 let key = item.key.clone();
                 let mut changed = false;
 
@@ -592,7 +591,6 @@ impl ConfigPalette {
                     self.reload_items_from_config();
                 }
             }
-        }
     }
 
     pub fn apply_changes(&mut self) -> anyhow::Result<()> {
diff --git a/vtcode-core/src/ui/tui/session/prompt_palette.rs b/vtcode-core/src/ui/tui/session/prompt_palette.rs
@@ -20,6 +20,12 @@ pub struct PromptPalette {
     filter_cache: std::collections::HashMap<String, Vec<PromptEntry>>,
 }
 
+impl Default for PromptPalette {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl PromptPalette {
     pub fn new() -> Self {
         Self {
diff --git a/vtcode-core/src/ui/tui/session/slash.rs b/vtcode-core/src/ui/tui/session/slash.rs
@@ -409,7 +409,7 @@ pub(super) fn autocomplete_slash_suggestion(session: &mut Session) -> bool {
             new_input.push(' ');
         }
         let position = new_input.len();
-        new_input.push_str(&suffix);
+        new_input.push_str(suffix);
         position
     };
 
diff --git a/vtcode-core/src/ui/tui/widgets/input.rs b/vtcode-core/src/ui/tui/widgets/input.rs
@@ -57,14 +57,13 @@ impl<'a> Widget for InputWidget<'a> {
         let mut status_line = None;
 
         // Calculate areas for input and status line
-        if area.height >= 2 {
-            if let Some(spans) = self.session.build_input_status_widget_data(area.width) {
+        if area.height >= 2
+            && let Some(spans) = self.session.build_input_status_widget_data(area.width) {
                 let block_height = area.height.saturating_sub(1).max(1);
                 input_area.height = block_height;
                 status_area = Some(Rect::new(area.x, area.y + block_height, area.width, 1));
                 status_line = Some(Line::from(spans));
             }
-        }
 
         // Create the border block first to get the inner area
         let temp_data = self.session.build_input_widget_data(1, 1); // Temporary data for style access
diff --git a/vtcode-core/src/ui/tui/widgets/modal.rs b/vtcode-core/src/ui/tui/widgets/modal.rs
@@ -127,7 +127,7 @@ impl<'a> ModalWidget<'a> {
             ModalType::Text { lines } => {
                 let width = lines
                     .iter()
-                    .map(|line| crate::ui::tui::style::measure_text_width(line) as u16)
+                    .map(|line| crate::ui::tui::style::measure_text_width(line))
                     .max()
                     .unwrap_or(40);
                 (width, lines.len(), 0, 0, false)
@@ -162,7 +162,7 @@ impl<'a> ModalWidget<'a> {
             ModalType::SecurePrompt { lines, .. } => {
                 let width = lines
                     .iter()
-                    .map(|line| crate::ui::tui::style::measure_text_width(line) as u16)
+                    .map(|line| crate::ui::tui::style::measure_text_width(line))
                     .max()
                     .unwrap_or(40)
                     .max(ui::MODAL_MIN_WIDTH);
@@ -263,14 +263,13 @@ impl<'a> ModalWidget<'a> {
         let layout = ModalListLayout::new(area, lines.len());
 
         // Render instructions if present
-        if let Some(text_area) = layout.text_area {
-            if !lines.is_empty() {
+        if let Some(text_area) = layout.text_area
+            && !lines.is_empty() {
                 self.render_instructions(text_area, buf, lines);
             }
-        }
 
         // Render list
-        self.render_modal_list(layout.list_area, buf, &*list_state);
+        self.render_modal_list(layout.list_area, buf, list_state);
     }
 
     fn render_wizard_modal(&self, area: Rect, buf: &mut Buffer, wizard_state: &WizardModalState) {
diff --git a/vtcode-core/src/ui/tui/widgets/session.rs b/vtcode-core/src/ui/tui/widgets/session.rs
@@ -71,7 +71,7 @@ impl<'a> SessionWidget<'a> {
     }
 }
 
-impl<'a> Widget for &'a mut SessionWidget<'_> {
+impl Widget for &mut SessionWidget<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         if area.width == 0 || area.height == 0 {
             return;
@@ -190,18 +190,16 @@ impl<'a> SessionWidget<'a> {
         // Only render the palette widgets that work with Buffer
 
         // Render file palette using builder pattern
-        if self.session.file_palette_active {
-            if let Some(palette) = self.session.file_palette.as_ref() {
+        if self.session.file_palette_active
+            && let Some(palette) = self.session.file_palette.as_ref() {
                 FilePaletteWidget::new(self.session, palette, viewport).render(viewport, buf);
             }
-        }
 
         // Render prompt palette using builder pattern
-        if self.session.prompt_palette_active {
-            if let Some(palette) = self.session.prompt_palette.as_ref() {
+        if self.session.prompt_palette_active
+            && let Some(palette) = self.session.prompt_palette.as_ref() {
                 PromptPaletteWidget::new(self.session, palette, viewport).render(viewport, buf);
             }
-        }
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -367,11 +367,10 @@ fn render_plan_markdown(plan: &TaskPlan) -> String {`
`367`	`367`	`);`
`368`	`368`	`}`
`369`	`369`
`370`		`- if let Some(explanation) = &plan.explanation {`
`371`		`- if !explanation.is_empty() {`
	`370`	`+ if let Some(explanation) = &plan.explanation`
	`371`	`+ && !explanation.is_empty() {`
`372`	`372`	`let _ = writeln!(output, "\nFocus: {}", explanation);`
`373`	`373`	`}`
`374`		`- }`
`375`	`374`
`376`	`375`	`let _ = writeln!(output, "\n## Steps");`
`377`	`376`	`for (idx, step) in plan.steps.iter().enumerate() {`
Original file line number	Diff line number	Diff line change
`@@ -2518,9 +2518,7 @@ impl ToolRegistry {`
`2518`	`2518`	`}`
`2519`	`2519`
`2520`	`2520`	`fn planning_allowed(name: &str) -> bool {`
`2521`		`- PLANNING_ALLOWED_TOOLS`
`2522`		`- .iter()`
`2523`		`- .any(\|allowed\| *allowed == name)`
	`2521`	`+ PLANNING_ALLOWED_TOOLS.contains(&name)`
`2524`	`2522`	`}`
`2525`	`2523`
`2526`	`2524`	`impl ToolRegistry {`
Original file line number	Diff line number	Diff line change
`@@ -197,11 +197,10 @@ fn parse_list_output(output: &str) -> ListStats {`
`197`	`197`	`} else {`
`198`	`198`	`stats.file_count += 1;`
`199`	`199`	`// Extract simple filename`
`200`		`- if let Some(name) = line.split('/').last() {`
`201`		`- if name.len() > 0 && name.len() < 50 {`
	`200`	`+ if let Some(name) = line.split('/').next_back()`
	`201`	`+ && !name.is_empty() && name.len() < 50 {`
`202`	`202`	`stats.sample_files.push(name.to_string());`
`203`	`203`	`}`
`204`		`- }`
`205`	`204`	`}`
`206`	`205`	`}`
`207`	`206`
`@@ -225,11 +224,10 @@ fn extract_symbols(line: &str, symbols: &mut std::collections::HashSet<String>)`
`225`	`224`	`for keyword in &["struct ", "impl ", "trait ", "enum "] {`
`226`	`225`	`if let Some(pos) = line.find(keyword) {`
`227`	`226`	`let after_kw = &line[pos + keyword.len()..];`
`228`		`- if let Some(first_word) = after_kw.split_whitespace().next() {`
`229`		`- if first_word.len() < 30 && !first_word.contains('{') {`
	`227`	`+ if let Some(first_word) = after_kw.split_whitespace().next()`
	`228`	`+ && first_word.len() < 30 && !first_word.contains('{') {`
`230`	`229`	`symbols.insert(first_word.to_string());`
`231`	`230`	`}`
`232`		`- }`
`233`	`231`	`}`
`234`	`232`	`}`
`235`	`233`	`}`
Original file line number	Diff line number	Diff line change
`@@ -371,8 +371,8 @@ impl ConfigPalette {`
`371`	`371`	`}`
`372`	`372`
`373`	`373`	`pub fn adjust_numeric_val(&mut self, delta: i64) {`
`374`		`- if let Some(index) = self.selected() {`
`375`		`- if let Some(item) = self.items.get(index) {`
	`374`	`+ if let Some(index) = self.selected()`
	`375`	`+ && let Some(item) = self.items.get(index) {`
`376`	`376`	`let key = item.key.clone();`
`377`	`377`	`let mut changed = false;`
`378`	`378`
`@@ -430,12 +430,11 @@ impl ConfigPalette {`
`430`	`430`	`self.reload_items_from_config();`
`431`	`431`	`}`
`432`	`432`	`}`
`433`		`- }`
`434`	`433`	`}`
`435`	`434`
`436`	`435`	`pub fn toggle_selected(&mut self) {`
`437`		`- if let Some(index) = self.selected() {`
`438`		`- if let Some(item) = self.items.get(index) {`
	`436`	`+ if let Some(index) = self.selected()`
	`437`	`+ && let Some(item) = self.items.get(index) {`
`439`	`438`	`let key = item.key.clone();`
`440`	`439`	`let mut changed = false;`
`441`	`440`
`@@ -592,7 +591,6 @@ impl ConfigPalette {`
`592`	`591`	`self.reload_items_from_config();`
`593`	`592`	`}`
`594`	`593`	`}`
`595`		`- }`
`596`	`594`	`}`
`597`	`595`
`598`	`596`	`pub fn apply_changes(&mut self) -> anyhow::Result<()> {`