| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 27 Dec 2025 06:48:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=342.208055,conversation_content-fragment;desc="conversation_content fragment";dur=1286.325853,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=361.746419,nginx;desc="NGINX";dur=1.419413,glb;desc="GLB";dur=96.755308
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=BfGMceglCNVjqBGzeThp7RM5CgDKTaIiYqhjRMjizyKSIOySBR%2BYA6VNVpfx4LP4AuQ3GAemn5OyKJMT8lqC9X6EyCa1D0qgfRSPyfn4tTt8jtVV8QJcejoY%2Fn7Mbu48V2dl15dtdjcdbAwG%2Fq%2BGpX862mW0QMdk0rGgzdej%2Fyjm66rLJUj8X8z3wPEJX7jU41QbEokAkRlxDmSmBs3MXp44eeM1jCwV3vW5HPlPk%2FACA%2F6EYLRwMG0%2BMz%2BCVDgASdxt%2BFi%2B8SEtKibe8TuOLQ%3D%3D--UKl5eZPCFsb3lUUJ--9t3Ph1u%2Btx0VSsMYDI9O%2Bw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1543836031.1766818133; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 06:48:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 06:48:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A9EA:1533AA:3FE0CA7:4CFB1FA:694F8155
libservo: Clean up Servo exports and export more at the root by mrobinson · Pull Request #40951 · servo/servo · GitHub
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
November 29, 2025 10:52
Copy link
Copy link
servo-highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 29, 2025
Copy link
Copy link
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
November 29, 2025 11:22
Copy link
Copy link
servo-highfive
removed
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 29, 2025
Copy link
Copy link
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 29, 2025
servo-highfive
added
S-tests-failed
The changes caused existing tests to fail.
and removed
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
labels
Nov 29, 2025
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
November 29, 2025 16:06
servo-highfive
added
S-awaiting-review
There is new code that needs to be reviewed.
and removed
S-tests-failed
The changes caused existing tests to fail.
labels
Nov 29, 2025
mrobinson
added
S-tests-failed
The changes caused existing tests to fail.
T-windows
Do a try run on Windows
and removed
S-awaiting-review
There is new code that needs to be reviewed.
labels
Nov 29, 2025
Copy link
Copy link
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
November 29, 2025 16:17
servo-highfive
added
S-awaiting-review
There is new code that needs to be reviewed.
and removed
S-tests-failed
The changes caused existing tests to fail.
labels
Nov 29, 2025
Copy link
Copy link
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 29, 2025
servo-highfive
added
S-tests-failed
The changes caused existing tests to fail.
and removed
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
labels
Nov 29, 2025
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
November 29, 2025 16:57
servo-highfive
removed
the
S-tests-failed
The changes caused existing tests to fail.
label
Nov 29, 2025
Copy link
Copy link
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 29, 2025
servo-highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 29, 2025
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
libservo: Clean up Servo exports and export more at the root #40951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
55a121e to
c3d43e3
Compare
|
🔨 Triggering try run (#19782896398) for OpenHarmony |
Bencher Report
servo-highfive
added
the
S-awaiting-review
Member
Author
|
This one is ready for review. |
|
|
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
c3d43e3 to
719dc41
Compare
|
🔨 Triggering try run (#19783210541) for OpenHarmony |
|
✨ Try run (#19783210541) succeeded. |
Taym95
approved these changes
Nov 29, 2025
servo-highfive
removed
the
S-awaiting-review
yezhizhen
approved these changes
Nov 29, 2025
Comment on lines
-7
to
-9
| //! This is a very simple library that wires all of Servo's components | ||
| //! together as type `Servo`, along with a generic client | ||
| //! implementing the `WindowMethods` trait, to create a working web |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of texts are actually changed. The blame might look bad.
But some texts below are actually changed.
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I have also removed some out of date information here, which I forgot to mention in the description of the PR. All of the documentation for the API needs a lot of work.
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
719dc41 to
f79c2aa
Compare
servo-highfive
added
S-awaiting-review
mrobinson
added
S-tests-failed
|
🔨 Triggering try run (#19786191511) for Windows |
|
|
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
f79c2aa to
4492c9a
Compare
servo-highfive
added
S-awaiting-review
|
🔨 Triggering try run (#19786309566) for Windows |
|
✨ Try run (#19786309566) succeeded. |
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
This change makes it easier for embedders to embed the types that they need by exporting almost everything necessary to use Servo at the root of libservo, apart from a few exceptions. In addition, the `Servo` is moved to its own file so that public exports can be more easily spotted from `components/servo/lib.rs`. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
4492c9a to
96b42b9
Compare
servo-highfive
removed
the
S-tests-failed
|
🔨 Triggering try run (#19786716293) for Android |
|
✨ Try run (#19786716293) succeeded. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This change makes it easier for embedders to embed the types that they
need by exporting almost everything necessary to use Servo at the root
of libservo, apart from a few exceptions. In addition, the
Servois movedto its own file so that public exports can be more easily spotted from
components/servo/lib.rs.Testing: This should not change behavior and is thus covered by existing tests.
Fixes: #18475.