| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 27 Dec 2025 06:22:37 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=376.54796,conversation_content-fragment;desc="conversation_content fragment";dur=556.35781,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=266.293476,nginx;desc="NGINX";dur=0.544315,glb;desc="GLB";dur=96.220198
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=S%2Bo9zUHLuM9F9IqmW5xAgw81HOahuShVZ7KZ2BPG139dfczilLb4kpgubCkOICUFPGCZa9fw7ZhxnPNCqoWXka2HewGIw9UH6%2BjiCD70NhMqpFdwznDKliY5aMmUeoYqAcwVS385Hl3UnGJUVepHZyWs5QCt%2BA4uYTqvF81hcHMXnFzbO4Gss2YZmfeDsfYqxCOTO90N9u%2Fkm5S4quNNWlMX7GKMSetyMpdmu8M%2B8hH2HrXBlWx6JkyfArqiQTnjR8qNyZA5BRoDIPmX9K8rIg%3D%3D--1wsFchHDinNc6RlW--0dwOV%2BdrqTEuBY8a3dcIgg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1777342696.1766816557; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 06:22:37 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 06:22:37 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E04E:2DDF35:3F8F684:4C9E31D:694F7B2C
libservo: Remove `Servo::animating()` by mrobinson · Pull Request #40799 · servo/servo · GitHub
libservo: Remove
servo-highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 21, 2025
servo-highfive
removed
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 21, 2025
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 21, 2025
servo-highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 21, 2025
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
libservo: Remove Servo::animating()
#40799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+4
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on `Sevo::animating()` in servoshell to drive the event loop, it is sufficient to just let the `RefreshDriver` wake it up when it is time to re-render. This allows us to remove `Servo::animating()` completely. It is a bit odd that there is a global API to track this, rather than per-`WebView` or window, so this change just removes it entirely. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
jdm
approved these changes
Nov 21, 2025
mrobinson
added a commit
to mrobinson/servo
that referenced
this pull request
Nov 25, 2025
This is dead code servo#40799, as it is never called. Remove the delegate call and the entire `ServoShellServoDelegate` as the only thing that it was doing was printing top-level errors which only happen when something goes very wrong. It's quite likely that backtraces printed earlier will be more useful. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
This is dead code #40799, as it is never called. Remove the delegate call and the entire `ServoShellServoDelegate` as the only thing that it was doing was printing top-level errors which only happen when something goes very wrong. It's quite likely that backtraces printed earlier will be more useful. Testing: This just removes dead code, so should be covered by existing tests. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Instead of relying on
Sevo::animating()in servoshell to drive theevent loop, it is sufficient to just let the
RefreshDriverwake it upwhen it is time to re-render.
This allows us to remove
Servo::animating()completely. It is a bitodd that there is a global API to track this, rather than per-
WebViewor window, so this change just removes it entirely.
Testing: This should make the main loop of headless servoshell more efficient,
but I do not think this difference is going to be observable in any way.