script: Have `FetchResponseListener::process_response_eof` consume the listener #40556

mrobinson · 2025-11-11T08:19:34Z

The goal of this change is to prevent having to copy so much data out of
listeners when a fetch completes, which will be particularly important
for off-the-main thread parsing of CSS (see #22478). This change has
pros and cons:

Pros:

This makes the design of the FetchResponseListener a great deal simpler.
They no longer individually store a dummy ResourceFetchTiming that is
only replaced right before process_response_eof.
The creation of the Arc<Mutex<FetchResponseListener>> in the
NetworkListener is abstracted away from clients and now they just
pass the FetchResponseListener to the fetch methods in the global.

Cons:

Now each FetchResponseListener must explicitly call submit_timing
instead of having the NetworkListener do it. This is arguably a bit
easier to follow in the code.
Since the internal data of the NetworkListener is now an
Arc<Mutex<Option<FetchResponseListener>>>, when the fetching code
needs to share state with the NetworkListener it either needs to
share an Option or some sort of internal state. In one case I've
stored the Option and in another case, I've stored a new inner
shared value.

Testing: This should not change observable behavior and is thus covered by existing tests.
Fixes: #22550

…e listener The goal of this change is to prevent having to copy so much data out of listeners when a fetch completes, which will be particularly important for off-the-main thread parsing of CSS (see servo#22478). This change has pros and cons: Pros: - This makes the design of the `FetchResponseListener` a great deal simpler. They no longer individually store a dummy `ResourceFetchTiming` that is only replaced right before `process_response_eof`. - The creation of the `Arc<Mutex<FetchResponseListener>>` in the `NetworkListener` is abstracted away from clients and now they just pass the `FetchResponseListener` to the fetch methods in the global. Cons: - Now each `FetchResponseListener` must explicitly call `submit_timing` instead of having the `NetworkListener` do it. This is arguably a bit easier to follow in the code. - Since the internal data of the `NetworkListener` is now an `Arc<Mutex<Option<FetchResponseListener>>>`, when the fetching code needs to share state with the `NetworkListener` it either needs to share an `Option` or some sort of internal state. In one case I've stored the `Option` and in another case, I've stored a new inner shared value. Signed-off-by: Martin Robinson <mrobinson@igalia.com> ste#

TimvdLippe · 2025-11-11T08:54:13Z

I like the cleanup. The timing call is unfortunate, so let's try to see if that's unnecessary? Maybe we can return Self as well and call it? Or do we require data that is not available in the caller?

If it's not possible, then I do think your solution is superior to the current state.

mrobinson · 2025-11-11T11:08:25Z

I like the cleanup. The timing call is unfortunate, so let's try to see if that's unnecessary? Maybe we can return Self as well and call it? Or do we require data that is not available in the caller?

Yeah, unfortunately the goal here is that process_response_eof should be able pick apart self without having to clone out the contained data, so we cannot then later pass self anywhere or return it. TBH, it is a little bit weird that the ResourceTimingData was stored on each listener individually. Maybe this approach is better than what we had before?

TimvdLippe

I think this is a step in the right direction

mrobinson · 2025-11-11T15:30:49Z

I've had to post a modification to this change which does two things:

Integrates EventSource into the typical workflow for starting fetch operations and properly creates a new FetchListener when restarting connections.
Add a new resource timing line for failed <script> tag loads. I missed one case in my original change.

github-actions · 2025-11-11T15:31:17Z

🔨 Triggering try run (#19270503294) for Linux (WPT)

github-actions · 2025-11-11T16:00:33Z

Test results for linux-wpt from try job (#19270503294):

Flaky unexpected result (36)

OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
TIMEOUT /IndexedDB/idbrequest-onupgradeneeded.any.html (#38895)
- PASS [expected FAIL] subtest: indexedDB.delete called from upgradeneeded handler
CRASH [expected OK] /_mozilla/mozilla/img_find_non_sibling_map.html
OK /_mozilla/webxr/create_session.https.html
- FAIL [expected PASS] subtest: create_session
```
can't access property "simulateDeviceConnection", navigator.xr.test is undefined
```

OK /_mozilla/webxr/obtain_frame.https.html

FAIL [expected PASS] subtest: obtain_frame

promise_test: Unhandled rejection with value: object "TypeError: can't access property "simulateDeviceConnection", navigator.xr.test is undefined"

CRASH [expected OK] /_webgl/conformance/ogles/GL/build/build_065_to_072.html
CRASH [expected OK] /_webgl/conformance/programs/gl-get-active-uniform.html
CRASH [expected OK] /_webgl/conformance/programs/gl-shader-test.html
CRASH [expected ERROR] /_webgl/conformance/textures/canvas/tex-2d-rgb-rgb-unsigned_byte.html
CRASH [expected OK] /_webgl/conformance/textures/image_bitmap_from_blob/tex-2d-alpha-alpha-unsigned_byte.html

OK [expected TIMEOUT] /cookiestore/httponly_cookies.https.window.html

FAIL [expected TIMEOUT] subtest: HttpOnly cookies are not observed

assert_equals: HttpOnly cookie we wrote using HTTP in cookie jar is invisible to script expected (undefined) undefined but got (string) "cspViolationReportCookie1=1"

FAIL [expected NOTRUN] subtest: HttpOnly cookies can not be set by document.cookie

assert_equals: Trying to store an HttpOnly cookie with document.cookie fails expected "cookie1=value1; cookie3=value3" but got "HTTPONLY-cookie=value; cookie1=value1; cookie3=value3"

FAIL [expected NOTRUN] subtest: HttpOnly cookies can not be set by CookieStore

assert_equals: httpOnly is not an option for CookieStore.set() expected "cookie1=value1; cookie2=value2; cookie3=value3" but got "HTTPONLY-cookie=value; cookie1=value1; cookie2=value2; cookie3=value3"

FAIL [expected NOTRUN] subtest: HttpOnly cookies are not deleted/overwritten

assert_equals: HttpOnly cookie is not deleted expected (string) "HTTPONLY-cookie=value" but got (undefined) undefined

FAIL [expected PASS] /css/css-backgrounds/background-size-041.html
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(khmer-mul)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(khmer-mul) (drawing text in a canvas)
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - empty name exists
- PASS [expected FAIL] subtest: Multiple values - name content attribute is ignored
CRASH [expected ERROR] /fetch/api/basic/header-value-null-byte.any.serviceworker.html
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
OK /fetch/fetch-later/new-window.https.window.html (#32036)
- FAIL [expected PASS] subtest: A same-origin window[target=''][features=''] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target=''][features='popup'] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target='_blank'][features=''] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target='_blank'][features='popup'] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
TIMEOUT [expected CRASH] /fetch/metadata/window-open.https.sub.html (#40339)
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected OK] /html/browsers/windows/browsing-context-names/choose-default-001.html

OK /html/dom/documents/resource-metadata-management/document-cookie.html

FAIL [expected PASS] subtest: document has no cookie

assert_equals: expected "" but got "domain-attribute-matches-host=0"

FAIL [expected PASS] subtest: document.cookie

assert_equals: expected "" but got "domain-attribute-matches-host=0"

FAIL [expected PASS] subtest: document.cookie 1

assert_equals: expected "a=b" but got "a=b; domain-attribute-matches-host=0"

CRASH [expected OK] /html/dom/partial-updates/tentative/template-contentmethod-replace.html
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work.
```
Test timed out
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
Test timed out
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload domInteractive > Original domInteractive
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
FAIL [expected PASS] /png/apng/fcTL-blend-source-nearly-transparent.html
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
CRASH [expected OK] /trusted-types/Node-multiple-arguments.html
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- TIMEOUT [expected PASS] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
CRASH [expected ERROR] /wasm/webapi/invalid-code.any.sharedworker.html
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
CRASH [expected ERROR] /workers/Worker-constructor-proto.any.serviceworker.html
ERROR [expected OK] /workers/baseurl/alpha/sharedworker-in-worker.html (#21315)

Stable unexpected results that are known to be intermittent (31)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
TIMEOUT /content-security-policy/inheritance/location-reload.html (#38983)
- PASS [expected FAIL] subtest: location.reload() of empty iframe.
OK /css/css-cascade/layer-font-face-override.html (#35935)
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 1
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 2
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
OK /fetch/api/response/response-stream-with-broken-then.any.html (#35419)
- PASS [expected FAIL] subtest: Attempt to inject {done: false, value: bye} via Object.prototype.then.
- PASS [expected FAIL] subtest: Attempt to inject value: undefined via Object.prototype.then.
- PASS [expected FAIL] subtest: Attempt to inject undefined via Object.prototype.then.
- PASS [expected FAIL] subtest: Attempt to inject 8.2 via Object.prototype.then.
- PASS [expected FAIL] subtest: intercepting arraybuffer to text conversion via Object.prototype.then should not be possible
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Cross-site
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
CRASH [expected OK] /fetch/metadata/generated/element-iframe.https.sub.html (#40341)
OK /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- FAIL [expected PASS] subtest: sec-fetch-site - Same site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Cross-Site -> Same Origin, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Cross-Site -> Cross-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Origin -> Same-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Site -> Same Origin, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - attributes: crossorigin=anonymous
- PASS [expected FAIL] subtest: sec-fetch-user - no attributes
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Same site, no attributes
OK /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-dest - Not sent to non-trustworthy cross-site destination, no attributes
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
```
assert_equals: expected "" but got "#fragment"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 1 (expected array [6, 3] got [6, 1])
```
ERROR [expected OK] /html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html (#25046)
TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/src_object_blob.html (#40340)
- TIMEOUT [expected PASS] subtest: HTMLMediaElement.srcObject blob
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in name (formdata event)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic test (formdata event)
```
assert_equals: expected "basic=test\r\n" but got ""
```
- PASS [expected FAIL] subtest: text/plain: Basic File test (formdata event)
- PASS [expected FAIL] subtest: text/plain: \r\n in name (formdata event)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic File test (normal form)
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)
OK [expected ERROR] /html/user-activation/no-activation-thru-escape-key.html (#40343)
OK /preload/preload-error.sub.html (#37177)
- PASS [expected FAIL] subtest: success (fetch): main
- PASS [expected FAIL] subtest: 404 (fetch): main
- PASS [expected FAIL] subtest: CORS (fetch): main
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- TIMEOUT [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```

Stable unexpected results (1)

OK /resource-timing/script-rt-entries.html
- PASS [expected FAIL] subtest: The RT entry for a non-existent script should be available when the script 'error' event fires

github-actions · 2025-11-11T16:00:43Z

⚠️ Try run (#19270503294) failed.

mrobinson · 2025-11-11T21:13:32Z

This seems to have fixed an issue with resource timing tests due to the fact that the resource timing is now set before events are fired. This is possible because now the process_response_eof method has flexibility about when exactly to set the timing. I've updated the test results.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>

mrobinson · 2025-11-11T22:24:48Z

Hrm. It seems that these changes had too many side effects on the resource timing code so I have made another attempt to preserve the old behavior (which was also wrong, it seems).

mrobinson requested a review from gterzian as a code owner November 11, 2025 08:19

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 11, 2025

TimvdLippe approved these changes Nov 11, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 11, 2025

TimvdLippe added this pull request to the merge queue Nov 11, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 11, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2025

mrobinson added the T-linux-wpt Do a try run of the WPT label Nov 11, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Nov 11, 2025

TimvdLippe approved these changes Nov 11, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 11, 2025

mrobinson force-pushed the consume-fetch-listener branch from 1a9da60 to f8b19f4 Compare November 11, 2025 21:12

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 11, 2025

mrobinson enabled auto-merge November 11, 2025 21:13

mrobinson added this pull request to the merge queue Nov 11, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 11, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2025

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 11, 2025

servo-highfive added the S-tests-failed The changes caused existing tests to fail. label Nov 11, 2025

Fix failing WPT tests

e4ab12f

Signed-off-by: Martin Robinson <mrobinson@igalia.com>

mrobinson force-pushed the consume-fetch-listener branch from f8b19f4 to e4ab12f Compare November 11, 2025 22:24

servo-highfive removed the S-tests-failed The changes caused existing tests to fail. label Nov 11, 2025

mrobinson enabled auto-merge November 11, 2025 22:24

mrobinson added this pull request to the merge queue Nov 11, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 11, 2025

Merged via the queue into servo:main with commit bfde51c Nov 11, 2025
32 checks passed

mrobinson deleted the consume-fetch-listener branch November 11, 2025 23:13

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

script: Have `FetchResponseListener::process_response_eof` consume the listener #40556

script: Have `FetchResponseListener::process_response_eof` consume the listener #40556

Uh oh!

mrobinson commented Nov 11, 2025

Uh oh!

TimvdLippe commented Nov 11, 2025

Uh oh!

mrobinson commented Nov 11, 2025

Uh oh!

TimvdLippe left a comment

Uh oh!

Uh oh!

mrobinson commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

mrobinson commented Nov 11, 2025

Uh oh!

Uh oh!

mrobinson commented Nov 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

script: Have FetchResponseListener::process_response_eof consume the listener #40556

script: Have FetchResponseListener::process_response_eof consume the listener #40556

Uh oh!

Conversation

mrobinson commented Nov 11, 2025

Uh oh!

TimvdLippe commented Nov 11, 2025

Uh oh!

mrobinson commented Nov 11, 2025

Uh oh!

TimvdLippe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mrobinson commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

mrobinson commented Nov 11, 2025

Uh oh!

Uh oh!

mrobinson commented Nov 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

script: Have `FetchResponseListener::process_response_eof` consume the listener #40556

script: Have `FetchResponseListener::process_response_eof` consume the listener #40556