| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 27 Dec 2025 09:31:10 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=328.153658,conversation_content-fragment;desc="conversation_content fragment";dur=970.466926,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=285.551003,nginx;desc="NGINX";dur=0.813991,glb;desc="GLB";dur=95.51601
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=cJkJprOOpxriNFHUBCMG%2BA90ZWFFj%2FIf5RUnHArk3Drtd83fjWw4n3LySrx3Av%2BN0StisosRzXx%2FuI5IEAjaCxLpLQ%2FcKfxn2uvYTnUlQJmeTMZ8pAl4AEuY9A%2FoFidy6d%2BsC3EQXLRNnNJOE9kVhkvXUNcHCmKohjmw8SxSXBPjhy2ljQ5pCorpIA2uwVBTXOvaaq5%2FYJ%2F54NsNlScdTs6HsIOndexcIut0gS1Ybxp1s1QKwjhFtIYnj7%2BZR4YXhcXblSUciH0n8W5NxS9a0Q%3D%3D--%2BdQhwZhGI6inq%2B%2F6--m%2FkJrFobYj7z48wdEY%2Fsnw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.686423443.1766827869; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 09:31:09 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 09:31:09 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 861C:272FBA:41B7F95:4F2FDB2:694FA75D
net: Do not implement `Serialize`/`Deserialize` for `RasterImage` and introduce``SharedRasterImage` by Narfinger · Pull Request #40459 · servo/servo · GitHub
net: Do not implement
Narfinger
force-pushed
the
image-cache-no-ipc
branch
2 times, most recently
from
November 6, 2025 13:21
Copy link
Copy link
Copy link
Narfinger
force-pushed
the
image-cache-no-ipc
branch
from
November 6, 2025 16:10
servo-highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 6, 2025
mrobinson
changed the title
net: Disallow RasterImage to be serialized and introduce SharedRasterImage
net: Do not implement Nov 7, 2025
Copy link
servo-highfive
removed
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 7, 2025
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 7, 2025
servo-highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 7, 2025
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
net: Do not implement Serialize/Deserialize for RasterImage and introduce`SharedRasterImage
#40459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narfinger
force-pushed
the
image-cache-no-ipc
branch
2 times, most recently
from
1d86d9e to
c1a4e39
Compare
mrobinson
requested changes
Nov 6, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor comments...
| pub icon_url: Option<ServoUrl>, | ||
| /// Icon's raw image data and metadata. | ||
| pub icon_resource: Option<Arc<RasterImage>>, | ||
| pub icon_resource: Option<Arc<SharedRasterImage>>, |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave all of these types as RasterImage but implement a From<SharedRasterImage> for RasterImage and just call into() when filling these fields.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notification is Serializable, so I think we need to keep this SharedRasterImage.
Add a new struct `SharedRasterImage` that allows serializeing. This can be constructed from RasterImage. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Narfinger
force-pushed
the
image-cache-no-ipc
branch
from
c1a4e39 to
3296850
Compare
servo-highfive
added
the
S-awaiting-review
mrobinson
changed the title
Serialize/Deserialize for RasterImage and introduce`SharedRasterImage
mrobinson
approved these changes
Nov 7, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give this a shot. If we notice a large performance regression we can revert it. I think we have eliminated a few copies in the image code already, so I'm pretty sure this is okay.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
RasterImage is now not seralizeable and backed by Vec storage. Add a new struct
SharedRasterImagethat allows serializeing. This can be constructed from RasterImage. This introduces some more copying but I think the tradeoff is ok. Newly introduced copies are for favicon response to the embedder and EmbedderNotifications.Testing: Should not change functionality, so covered by existing tests.
Fixes: #39626 and related issues.