| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 27 Dec 2025 22:20:38 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=404.803692,conversation_content-fragment;desc="conversation_content fragment";dur=705.4862,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=1173.401166,nginx;desc="NGINX";dur=1.438914,glb;desc="GLB";dur=97.37202
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Nj7L0lky7fev5XZnirDgKc3qa45k56AKfWamPh%2FTZhVOFzj4PzOWJXc1oRC4IG%2B7xnpmHd4DbzAtf0DhiuFIYRLLSXPZwcWG8EG%2F%2BCPqls4PZOJFJ5SH24WelDmI%2BItewT2QXS4sEWE0QFHnpVHDmev2DnHEHjjVd9Vv8v7tDNffxAT6o1f11GRtdNssEK%2Bp3QlzYZda0CUdCG4mgj%2Bo9PMTB7KyQT7Aalo4lBLNVcsAiWLjNaQGj1FvJSu%2BxbJW08PdeKRi%2BK6igKOh9QrHnA%3D%3D--QOYH90PrA7AXbV34--pjZ8jwLgvOAf38HHelDa4A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.932111991.1766874037; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 22:20:37 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 22:20:37 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E30A:291923:48E4DB9:57D5549:69505BB5
libservo: Integrate context menu into the show_embedder_control API by mrobinson · Pull Request #40402 · servo/servo · GitHub
servo-highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 4, 2025
servo-highfive
removed
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 4, 2025
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2025
servo-highfive
added
S-tests-failed
The changes caused existing tests to fail.
and removed
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
labels
Nov 4, 2025
mrobinson
force-pushed
the
context-menu
branch
from
November 4, 2025 18:13
servo-highfive
added
S-awaiting-review
There is new code that needs to be reviewed.
and removed
S-tests-failed
The changes caused existing tests to fail.
labels
Nov 4, 2025
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2025
servo-highfive
added
S-tests-failed
The changes caused existing tests to fail.
and removed
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
labels
Nov 4, 2025
mrobinson
force-pushed
the
context-menu
branch
from
November 4, 2025 19:27
servo-highfive
removed
the
S-tests-failed
The changes caused existing tests to fail.
label
Nov 4, 2025
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2025
servo-highfive
added
S-tests-failed
The changes caused existing tests to fail.
and removed
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
labels
Nov 4, 2025
mrobinson
force-pushed
the
context-menu
branch
from
November 4, 2025 20:43
servo-highfive
removed
the
S-tests-failed
The changes caused existing tests to fail.
label
Nov 4, 2025
Copy link
Copy link
Copy link
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 4, 2025
servo-highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 4, 2025
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
libservo: Integrate context menu into the show_embedder_control API #40402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servo-highfive
added
the
S-awaiting-review
atbrakhi
approved these changes
Nov 4, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
mrobinson
force-pushed
the
context-menu
branch
from
d266fc4 to
182385d
Compare
servo-highfive
added
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
mrobinson
force-pushed
the
context-menu
branch
from
182385d to
1d25b25
Compare
servo-highfive
removed
the
S-tests-failed
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
This PR integrates showing context menus into the `WebViewDelegate::show_embedder_control` API. In addition, `ContextMenuItem` and `ContextMenuAction` data types are exposed which abstract away the different components of the context menu. Later changes will implement this API for servoshell as well as add element-specific actions such as "Select All" and "Copy Image URL". Co-authored-by: atbrakhi <atbrakhi@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
force-pushed
the
context-menu
branch
from
1d25b25 to
2d41b31
Compare
servo-highfive
removed
the
S-tests-failed
|
🔨 Triggering try run (#19082277657) for OpenHarmony |
Bencher Report
|
✨ Try run (#19082277657) succeeded. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR integrates showing context menus into the
WebViewDelegate::show_embedder_controlAPI. In addition,ContextMenuItemandContextMenuActiondata types are exposed whichabstract away the different components of the context menu. Later
changes will implement this API for servoshell as well as add
element-specific actions such as "Select All" and "Copy Image URL".
Testing: This change adds a WebView API test.