You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I always thought that exceptions thrown in namespace resolver callbacks should be propagated to the call site of document.evaluate.
That is not the case - the exception is silently swallowed and you get a namespace error, the same as if the callback had returned any other invalid value.
Testing: New web platform tests start to pass Fixes#39931
Part of #34527
Firefox somehow throws both a type error and a namespace DOMException in the same document.evaluate call, which matches the test expectations. I wasn't able to replicate that, but if chrome isn't doing it then there's likely no point...
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I always thought that exceptions thrown in namespace resolver callbacks should be propagated to the call site of
document.evaluate.That is not the case - the exception is silently swallowed and you get a namespace error, the same as if the callback had returned any other invalid value.
Testing: New web platform tests start to pass
Fixes #39931
Part of #34527