| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 29 Dec 2025 02:32:23 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=332.654239,conversation_content-fragment;desc="conversation_content fragment";dur=913.024018,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=314.131875,nginx;desc="NGINX";dur=0.48785,glb;desc="GLB";dur=97.521952
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=fdRAjHnBn7ReXl%2F6jmzY%2BHzNf5DAvPURTut8d2AeKGbU%2FKur2%2BgdFcxEIITfeMyRIcR0atYAT4exeK%2FcRXPhTKOJTHslderakkAn2ZLBQRt9DoIlPcgvhAG9CxQJK6VjDCdEYtyQJmJbPQ3BWlTnzbGLpTY2VlNlsygHptn%2Bc6sC1A42aTGeIHAYJIuoHSVHbEGOCeT%2FoxS5gpzqJJBh%2Ff9%2FORFx0jeqgBWDu6e2pxOxTTlizHqXH3HfYLQHh0O1A9%2BNikRrk%2BNu%2BvIm71q%2Brg%3D%3D--FJndZSFwJ5TMFPcx--LtboDPNUTFi4CKDoI71oXQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1533698500.1766975542; Path=/; Domain=github.com; Expires=Tue, 29 Dec 2026 02:32:22 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 29 Dec 2026 02:32:22 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A23C:268821:56BF5FB:6917328:6951E836
ohos: Fix JIT detection by jschwe · Pull Request #40130 · servo/servo · GitHub
jschwe
force-pushed
the
detect_jit_support2
branch
3 times, most recently
from
October 24, 2025 11:06
Copy link
jschwe
force-pushed
the
detect_jit_support2
branch
from
October 24, 2025 11:29
Copy link
Copy link
servo-highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Oct 24, 2025
servo-highfive
removed
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Oct 24, 2025
servo-highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Oct 24, 2025
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Oct 24, 2025
servo-highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Oct 24, 2025
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
ohos: Fix JIT detection #40130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ohos: Fix JIT detection #40130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8096553 to
a3369e5
Compare
|
🔨 Triggering try run (#18778210031) for OpenHarmony |
On recent versions of HarmonyOS the previous JIT detection does not appear to work anymore, since the second `mmap` succeeds. This moves the failure in spidermonkey to a later point, when SM remaps memory to be writable. On recent versions of HOS I observed that the `PROT_WRITE` permission was silently ignored by mprotect, which lead to a crash later on the first attempt to write to the memory region. It's not exactly easy to determine if one can write to a memory location (if mprotect lies to you), but we can use `read` to check if the memory region is writable (without triggering a segfault), since `read` will return an error for invalid addresses (which is possible since the writing is handled in the kernel). Since this solution does add more unsafe code than before, we only use this detection on OpenHarmony, although we could use it on more platforms later if there are other platforms which also may have JIT forbidden. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Since we now have runtime detection if JIT is supported, we don't need to explicitly disable JIT. This will be useful if we test on ohos devices that support JIT. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
9a12f4a to
dc89985
Compare
|
✨ Try run (#18778210031) succeeded. |
sagudev
reviewed
Oct 24, 2025
sagudev
approved these changes
Oct 24, 2025
Co-authored-by: Sam <16504129+sagudev@users.noreply.github.com> Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
On recent versions of HarmonyOS the previous JIT detection does not appear to work anymore, since the second
mmapsucceeds. This moves the failure in spidermonkey to a later point, when SM remaps memory to be writable. On recent versions of HOS I observed that thePROT_WRITEpermission was silently ignored by mprotect, which lead to a crash later on the first attempt to write to the memory region.It's not exactly easy to determine if one can write to a memory location (if mprotect lies to you), but we can use
readto check if the memory region is writable (without triggering a segfault), sincereadwill return an error for invalid addresses (which is possible since the writing is handled in the kernel).Since this solution does add more unsafe code than before, we only use this detection on OpenHarmony, although we could use it on more platforms later if there are other platforms which also may have JIT forbidden.
Testing: Removing the explicit
--pref js_disable_jit=truemeans the detection is tested in CI.Fixes: #40029