You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focusing the location bar in the Android app shows the onscreen keyboard, but clicking on a link in the current document does not make it disappear. This change ensures the input focus is reset appropriately and ensures the keyboard disappear when the location bar is not being edited.
Testing: Manually tested. No automated tests for Android app at this time. Fixes: #40008
The reason will be displayed to describe this comment to others. Learn more.
Do we have to request focus on each touch event? Also, I noticed that the focus change listener we add in the activity here never gets called. Could this be related to the current issue?
The reason will be displayed to describe this comment to others. Learn more.
I'm having trouble imagining what alternatives there are to requesting focus on input. Also, the focus listener is definitely called in my testing—how are you determining that?
The reason will be displayed to describe this comment to others. Learn more.
I'm having trouble imagining what alternatives there are to requesting focus on input.
My concern was that requestFocus might be too costly to be called on every touch event, so maybe there could be an alternative where we requestFocus only when we know the view doesn't have it already. I don't know about the actual cost of requestFocus though.
Also, the focus listener is definitely called in my testing—how are you determining that?
Yep, it does get called. I was using assert false as the body, but I didn't realize assertions are disabled in release builds. The debug build confirms that it is called.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focusing the location bar in the Android app shows the onscreen keyboard, but clicking on a link in the current document does not make it disappear. This change ensures the input focus is reset appropriately and ensures the keyboard disappear when the location bar is not being edited.
Testing: Manually tested. No automated tests for Android app at this time.
Fixes: #40008