| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 27 Dec 2025 11:48:44 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=378.398361,conversation_content-fragment;desc="conversation_content fragment";dur=1035.020888,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=434.468609,nginx;desc="NGINX";dur=1.377411,glb;desc="GLB";dur=97.73347
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=KjpeWPkogmA3EnYHN5E6scfVREiZokxh1AgYLgSKyxALgw8P%2BlxZBdt1FozueNyNfqlRJVngu05Z0z9gnEO0XXxR4rXPpFumWQUqldTxQSuANRn%2BjYZgp1oRtDhQRP0kHjt8nxaBXsP7IbxlPc5e2cBKN20ruXRhTic%2Bc9UQoUunySbVR6nWCHFtTA3TimnPxu%2BhTazDnBC0TJGinSH%2F5O4E3ScqbmD7S8jFLQ82ucuSx0K46AL5pcDo%2BiM0fMH1y7VP1FSfUYObm%2BIYli9TRw%3D%3D--xJ771VJ8bTWeT6zo--0uwf0Bg7YkTQm1ovzDEPDQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1849768537.1766836123; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 11:48:43 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 11:48:43 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 84C4:329234:4321751:50CE3BC:694FC79B
libservo: Rename `WebView::set_pinch_zoom` to `WebView::pinch_zoom` by mrobinson · Pull Request #39868 · servo/servo · GitHub
libservo: Rename
libservo: Rename
servo-highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Oct 14, 2025
servo-highfive
removed
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Oct 14, 2025
Copy link
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Oct 14, 2025
servo-highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Oct 14, 2025
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
libservo: Rename WebView::set_pinch_zoom to WebView::pinch_zoom
#39868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
atbrakhi
merged 1 commit into
servo:main
from
mrobinson:make-pinch-zoom-make-more-sense
Oct 14, 2025
Merged
libservo: Rename WebView::set_pinch_zoom to WebView::pinch_zoom
#39868
atbrakhi
merged 1 commit into
servo:main
from
mrobinson:make-pinch-zoom-make-more-sense
Oct 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is meant to make it more obvious that adjusting the pinch zoom of a `WebView` works differently than adjusting the page zoom. New pinch zoom values are *always* zoom deltas, that is they are always multiplied by the current pinch zoom value. This is due to the way that system APIs and Servo's internal touch handler provide values. In addition, stop clamping the pinch zoom by the page zoom clamp values. They aren't meant for that. Instead set up some reasonable clamping values for pinch zoom in the compositor. Also add more rustdoc for public API. Co-authored-by: Rakhi Sharma <atbrakhi@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com>
servo-highfive
added
the
S-awaiting-review
atbrakhi
approved these changes
Oct 14, 2025
servo-highfive
removed
the
S-awaiting-review
yezhizhen
reviewed
Oct 14, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New pinch zoom values are always zoom deltas, that is they are always
multiplied by the current pinch zoom value.
Why is it called delta? delta sounds more like addition/subtraction.
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Member
Author
Good point. We should consider a new name. |
kongbai1996
reviewed
Nov 4, 2025
| } | ||
|
|
||
| fn set_pinch_zoom_level(&mut self, mut zoom: f32) -> bool { | ||
| if let Some(viewport) = self.viewport_description.as_ref() { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect deletion logic; it should be restricted using self.viewport_description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This change is meant to make it more obvious that adjusting the pinch
zoom of a
WebViewworks differently than adjusting the page zoom.New pinch zoom values are always zoom deltas, that is they are always
multiplied by the current pinch zoom value. This is due to the way that
system APIs and Servo's internal touch handler provide values.
In addition, stop clamping the pinch zoom by the page zoom clamp values.
They aren't meant for that. Instead set up some reasonable clamping
values for pinch zoom in the compositor.
Also add more rustdoc for public API.
Testing: The changes to API naming do not really need tests, and the changes to
behavior (the clamping) can't be easily tested now as there is no way currently
to read the current pinch zoom level of the WebView. This requires more API in
the renderer.