You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Android interface needs some way to communciate click events to
Servo, so the JNI layer needs to expose a click event. Even though there
is no longer a "click" action in the API, we can implement this behavior
via a mouse button down and then mouse button up event, which should be
a more complete implementation in the DOM.
Testing: There currently aren't tests for Android interaction via the Java layer
(which is one reason why this regression happened sadly). Fixes#39742.
Ah, sorry. The ServoView which extends SurfaceView exposes a click method in the API as well using it to handle onSingleTapUp. Probably these tap events should be interpreted properly, but that seems like a larger change.
Seems fine to me to fix the regression, although I do wonder if this should make us re-evaluate the decision to completely remove the click event.
"click" is an internal DOM concept that should probably not be exposed to the API probably. They are produced by platform APIs so every embedder had to implement them, which could well mean that simple mistakes in the embedder could lead to non-conformant behavior according to the specification.
I think probably what we want to do is to remove the "click" event from the ServoView API entirely.
Ah, so the click() method in SevoView is an implementation detail, and not something we need to implement on Android? Then, yeah - we should probably remove it and wire up the up / down events to touch up / touch down.
The Android interface needs some way to communciate click events to
Servo, so the JNI layer needs to expose a click event. Even though there
is no longer a "click" action in the API, we can implement this behavior
via a mouse button down and then mouse button up event, which should be
a more complete implementation in the DOM.
This fixes a regression from servo#39705.
Fixesservo#39742.
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
The Android interface needs some way to communciate click events to
Servo, so the JNI layer needs to expose a click event. Even though there
is no longer a "click" action in the API, we can implement this behavior
via a mouse button down and then mouse button up event, which should be
a more complete implementation in the DOM.
This fixes a regression from #39705.
Testing: There currently aren't tests for Android interaction via the
Java layer
(which is one reason why this regression happened sadly).
Fixes#39742.
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android interface needs some way to communciate click events to
Servo, so the JNI layer needs to expose a click event. Even though there
is no longer a "click" action in the API, we can implement this behavior
via a mouse button down and then mouse button up event, which should be
a more complete implementation in the DOM.
This fixes a regression from #39705.
Testing: There currently aren't tests for Android interaction via the Java layer
(which is one reason why this regression happened sadly).
Fixes #39742.