libservo: Remove `MouseButtonAction::Click` from the API #39705

mrobinson · 2025-10-07T07:02:36Z

The embedder should never be responsible for triggering click events, so
this change removes that possibility from the API. In addition,
triggering of click events is simplified by moving the logic to the
DocumentEventHandler. This has the benefit of making behavior
consistent between in-process and out-of-process <iframe>s. Now click
events are never triggered when the button up and down cross frame
boundaries.

Testing: This should be covered by existing tests.

yezhizhen

Nice change!

yezhizhen · 2025-10-07T07:35:13Z

components/constellation/constellation.rs

-        // TODO: Click should be handled internally in the `Document`.
-        if let InputEvent::MouseButton(event) = &event {
-            if event.action == MouseButtonAction::Click {
-                self.pressed_mouse_buttons = 0;
-            }
-        }
-


Yeah this is some leftover. Semantically dead code.

yezhizhen · 2025-10-07T07:36:33Z

Would anything be changed if you run try action with servodriver?

mrobinson · 2025-10-07T07:42:28Z

Would anything be changed if you run try action with servodriver?

I don't think so, but I definitely want to double-check the WebDriver conformance tests before landing.

github-actions · 2025-10-07T07:44:44Z

🔨 Triggering try run (#18305654575) for Linux (WPT)

github-actions · 2025-10-07T08:21:15Z

Test results for linux-wpt from try job (#18305654575):

Flaky unexpected result (20)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
FAIL [expected PASS] /_mozilla/gfx-rs-gecko/descriptor-ranges.html (#23258)
FAIL [expected PASS] /css/WOFF2/metadatadisplay-well-formed-006.xht
FAIL [expected PASS] /css/css-fonts/font-palette.html
FAIL [expected PASS] /css/selectors/invalidation/class-id-attr.html
CRASH [expected TIMEOUT] /html/anonymous-iframe/indexeddb.tentative.https.window.html (#39254)
OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
- PASS [expected FAIL] subtest: Link with onclick form submit to javascript url with document.write and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
- PASS [expected FAIL] subtest: opener of discarded auxiliary browsing context
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected FAIL] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out
```
OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
- FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload
```
uncaught exception: Error: assert_equals: expected "https://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"
```
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "https://web-platform.test:8000"
```

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

OK /intersection-observer/callback-cross-realm-report-exception.html (#38829)
- FAIL [expected PASS] subtest: IntersectionObserver reports the exception from its callback in the callback's global object
```
assert_array_equals: lengths differ, expected array ["frame1"] length 1, got [] length 0
```
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK /preload/preload-xhr.html (#39092)
- FAIL [expected PASS] subtest: Make an XHR request immediately after creating link rel=preload.
```
assert_equals: resources/dummy.xml?token=0685bc80-5329-43a7-8878-866db98ba34f expected 1 but got 0
```
OK /webdriver/tests/classic/element_clear/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchElementException: no such element (404)
```

Stable unexpected results that are known to be intermittent (22)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
TIMEOUT [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-dest
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-user
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Same site
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;
```
- TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
Test timed out
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html (#39694)
- PASS [expected FAIL] subtest: Meta refresh is blocked by the allow-scripts sandbox flag at its creation time, not when refresh comes due
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic test (normal form)
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)
OK /preload/preload-error.sub.html (#37177)
- PASS [expected FAIL] subtest: success (fetch): main
OK [expected TIMEOUT] /resource-timing/nested-context-navigations-iframe.html (#24311)
- PASS [expected NOTRUN] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- PASS [expected NOTRUN] subtest: Test that iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that crossorigin iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that iframe refreshes are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe refreshes are not observable by the parent
OK /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- FAIL [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /webdriver/tests/classic/dismiss_alert/dismiss.py (#39098)
- PASS [expected FAIL] subtest: test_dismiss_in_popup_window

github-actions · 2025-10-07T08:21:24Z

✨ Try run (#18305654575) succeeded.

The embedder should never be responsible for triggering click events, so this change removes that possibility from the API. In addition, triggering of click events is simplified by moving the logic to the `DocumentEventHandler`. This has the benefit of making behavior consistent between in-process and out-of-process `<iframe>`s. Now click events are never triggered when the button up and down cross frame boundaries. Signed-off-by: Martin Robinson <mrobinson@igalia.com>

github-actions · 2025-10-07T12:28:59Z

🔨 Triggering try run (#18312643709) for Android

github-actions · 2025-10-07T12:54:36Z

✨ Try run (#18312643709) succeeded.

The Android interface needs some way to communciate click events to Servo, so the JNI layer needs to expose a click event. Even though there is no longer a "click" action in the API, we can implement this behavior via a mouse button down and then mouse button up event, which should be a more complete implementation in the DOM. This fixes a regression from servo#39705. Fixes servo#39742.

The Android interface needs some way to communciate click events to Servo, so the JNI layer needs to expose a click event. Even though there is no longer a "click" action in the API, we can implement this behavior via a mouse button down and then mouse button up event, which should be a more complete implementation in the DOM. This fixes a regression from servo#39705. Fixes servo#39742. Signed-off-by: Martin Robinson <mrobinson@igalia.com>

The Android interface needs some way to communciate click events to Servo, so the JNI layer needs to expose a click event. Even though there is no longer a "click" action in the API, we can implement this behavior via a mouse button down and then mouse button up event, which should be a more complete implementation in the DOM. This fixes a regression from #39705. Testing: There currently aren't tests for Android interaction via the Java layer (which is one reason why this regression happened sadly). Fixes #39742. Signed-off-by: Martin Robinson <mrobinson@igalia.com>

mrobinson requested a review from gterzian as a code owner October 7, 2025 07:02

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 7, 2025

yezhizhen approved these changes Oct 7, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 7, 2025

mrobinson added the T-linux-wpt Do a try run of the WPT label Oct 7, 2025

mrobinson changed the title ~~libservo: Remove `MouseButtonAction::Click from the API~~ libservo: Remove MouseButtonAction::Click from the API Oct 7, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Oct 7, 2025

nacho mentioned this pull request Oct 7, 2025

Remove sending clicks once servo removes the api nacho/servo-gtk#15

Closed

mrobinson added this pull request to the merge queue Oct 7, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 7, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2025

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 7, 2025

mrobinson force-pushed the remove-click-button branch from 1d5fc47 to d3d8f1e Compare October 7, 2025 12:28

mrobinson requested a review from jschwe as a code owner October 7, 2025 12:28

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 7, 2025

mrobinson added the T-android Do a try run on Android label Oct 7, 2025

github-actions bot removed the T-android Do a try run on Android label Oct 7, 2025

mrobinson enabled auto-merge October 7, 2025 12:59

mrobinson added this pull request to the merge queue Oct 7, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 7, 2025

Merged via the queue into servo:main with commit fbbdce2 Oct 7, 2025
39 checks passed

mrobinson deleted the remove-click-button branch October 7, 2025 13:37

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 7, 2025

jdm mentioned this pull request Oct 9, 2025

Servo android stops when interacting with a website #39742

Closed

mrobinson mentioned this pull request Oct 10, 2025

servoshell: Reimplement "onClick" action on Android #39771

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

libservo: Remove `MouseButtonAction::Click` from the API #39705

libservo: Remove `MouseButtonAction::Click` from the API #39705

Uh oh!

mrobinson commented Oct 7, 2025

Uh oh!

yezhizhen left a comment

Uh oh!

yezhizhen Oct 7, 2025

Uh oh!

yezhizhen commented Oct 7, 2025 •

edited

Loading

Uh oh!

mrobinson commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

libservo: Remove MouseButtonAction::Click from the API #39705

libservo: Remove MouseButtonAction::Click from the API #39705

Uh oh!

Conversation

mrobinson commented Oct 7, 2025

Uh oh!

yezhizhen left a comment

Choose a reason for hiding this comment

Uh oh!

yezhizhen Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

yezhizhen commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrobinson commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

libservo: Remove `MouseButtonAction::Click` from the API #39705

libservo: Remove `MouseButtonAction::Click` from the API #39705

yezhizhen commented Oct 7, 2025 •

edited

Loading