| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 27 Dec 2025 13:02:18 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=404.73417,conversation_content-fragment;desc="conversation_content fragment";dur=1398.760052,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=436.491551,nginx;desc="NGINX";dur=1.261176,glb;desc="GLB";dur=98.12812
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=wyweDGOB%2BqB3ki0PRnTB1aYtbllhMpYvSQJlj8K5bcsjMB2cSL8S%2B%2B%2Fpwd3OHctc9uOfIESdrO7r5EFunv%2B0eqknRlR%2FTXwWMzWji2XI%2FA2LkXlea%2BetJ28cFXjdtXRe2LwH6RD3tAr03k71qQSJWgNrpyX9DVmp1n6GCJPPdEOWCdmr8njDVDr1oWTmIUDvhTcPAQldNwEskLQSi40PbNXYqhGMM%2FfergibhERAiW6KQsEdacU%2FUZ6Hfd9kq5NxtBihgOFrUJe9og3yVWtwtw%3D%3D--3eSr3G6l0xQyAlld--Vrew61OwRfBtczvEvOtqDw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1992020338.1766840536; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 13:02:16 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 13:02:16 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AB04:1F5657:43D344A:51C082C:694FD8D8
script: Skip running layout when only updating images or canvas by mrobinson · Pull Request #38991 · servo/servo · GitHub
Copy link
Copy link
mrobinson
force-pushed
the
skip-layout-when-updating-images
branch
2 times, most recently
from
August 28, 2025 10:19
mrobinson
added
T-webgpu
Do a try run on Linux of the WebGPU CTS
A-content/canvas
2d canvas API
labels
Aug 28, 2025
Copy link
mrobinson
added
A-content/webgpu
The WebGPU implementation.
T-webgpu
Do a try run on Linux of the WebGPU CTS
labels
Aug 28, 2025
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
mrobinson
force-pushed
the
skip-layout-when-updating-images
branch
from
October 3, 2025 10:13
servo-highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Oct 3, 2025
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Oct 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 3, 2025
servo-highfive
added
S-tests-failed
The changes caused existing tests to fail.
and removed
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
labels
Oct 3, 2025
servo-highfive
removed
the
S-tests-failed
The changes caused existing tests to fail.
label
Oct 3, 2025
servo-highfive
added
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
and removed
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
labels
Oct 3, 2025
mrobinson
force-pushed
the
skip-layout-when-updating-images
branch
from
October 3, 2025 11:46
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Oct 3, 2025
servo-highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Oct 3, 2025
mrobinson
force-pushed
the
skip-layout-when-updating-images
branch
from
October 3, 2025 13:04
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Oct 3, 2025
servo-highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Oct 3, 2025
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
script: Skip running layout when only updating images or canvas #38991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrobinson
merged 1 commit into
servo:main
from
mrobinson:skip-layout-when-updating-images
Oct 3, 2025
Merged
script: Skip running layout when only updating images or canvas #38991
mrobinson
merged 1 commit into
servo:main
from
mrobinson:skip-layout-when-updating-images
Oct 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#17290226074) for Linux (Production, WPT) |
|
|
sagudev
reviewed
Aug 28, 2025
mrobinson
force-pushed
the
skip-layout-when-updating-images
branch
2 times, most recently
from
0be2e0a to
d29ca6a
Compare
mrobinson
added
T-webgpu
|
🔨 Triggering try run (#17293175543) for Linux (Production, WPT) |
mrobinson
added
A-content/webgpu
|
🔨 Triggering try run (#17293177114) for Linux (Production, WPT) |
|
Test results for linux-wpt from try job (#17293177114): Flaky unexpected result (7)
Stable unexpected results (21)
|
|
|
sagudev
reviewed
Aug 28, 2025
Member
sagudev
left a comment
sagudev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Test results for linux-wpt from try job (#17293175543): Flaky unexpected result (18)
Stable unexpected results (21)
|
|
|
Contributor
|
I believe this can also optimize these reflows triggerred by fetch state change of css background image or border image resources. Besides, I am considering the following optimization: when only updating the fetch state of image resources, skip running restyle and incremental box tree construction, and instead only running layout and subsequent reflow phases. We maybe need to add a new kind of Then we might need to run minor incremental box tree construction that only acts on nodes related to Do you think that is feasible? |
Contributor
Please ignore it for now. I believe it is not yet the right time to implement this idea. It relies on the complete version of storing layout data for multi-level nested pseudo-element. |
Member
|
though: When clearing canvas (without updating the image like we will do for webgpu) we still need to mark it as dirty otherwise layout uses cached imagekey based on my testing from making async image updates. |
Member
Author
This design means that WebGPU canvases will never be able to skip layout when clearing which seems like it will seriously limit performance. If possible you want to avoid doing a layout 60 times a second! Instead of setting a |
Member
That could work, yes. Although I think the benefit of not setting imagekey is that we could avoided alloc and sending it. Currently I think we can only do this by setting externalimage as invalid texture (id 0). |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2025
…er separately (#39627) Before both canvas updates and layout had their own `Epoch`. This change makes it so the `Epoch` is shared. This means that display lists might have non-consecutive `Epoch`s, but will also allow for the `Epoch` in the renderer to update even when no new display list is produced. This is important for #38991. In that PR the display list step can be skipped for canvas-only updates, but the `Epoch` in the renderer must still advance. Testing: This shouldn't change the user-observable behavior and is thus covered by existing tests. It should prevent flakiness once #38991 lands. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
force-pushed
the
skip-layout-when-updating-images
branch
from
bcfb136 to
b8be9d6
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
removed
the
S-tests-failed
servo-highfive
added
S-awaiting-merge
mrobinson
force-pushed
the
skip-layout-when-updating-images
branch
from
b8be9d6 to
8ab2bda
Compare
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Add a new super-lightweight layout mode that avoids any layout when canvas is updated or animated images progress to the next frame. In the future this can also be used for video elements. Currently, WebGPU does not seem to track when canvases are dirty, so a very high-level flag is used in the cases when WebGPU canvases are actually marked as dirty (not the majority of the time). Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
mrobinson
force-pushed
the
skip-layout-when-updating-images
branch
from
8ab2bda to
f4bf18c
Compare
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-content/canvas
2d canvas API
A-content/webgpu
The WebGPU implementation.
S-awaiting-review
There is new code that needs to be reviewed.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Add a new super-lightweight layout mode that avoids any layout when
canvas is updated or animated images progress to the next frame. In the
future this can also be used for video elements.
Testing: This is a performance optimization, so shouldn't change any
WPT test results.