| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 27 Dec 2025 09:33:28 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=440.784462,conversation_content-fragment;desc="conversation_content fragment";dur=1841.218027,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=415.689546,nginx;desc="NGINX";dur=0.800358,glb;desc="GLB";dur=97.261359
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=5b3oqpdCApLHufknXRq0oIakUw3t9eTxYnaUj2a8uke7sSCH1qQsTtQLDeiuBbz3Bz8w4gfXPau5biyYw1KUK7giWB%2FS7vok0nvtHUzy5%2F%2BJvcyTgnaJ%2FJLt0v6SNUeg5hkTgU%2B%2FMrQXchdRfgvGkUBR2x4Ss%2FKhKUalbHyMpiEry%2FP%2BF7jFeqqtFsf08GHgg4t52I10OSuLN6TbluE6vSqrXSytiINwK3sKox889pI2sEB%2BA6T1ebTpCiUkThL0OzlMBDYDcsHZn2jZsg4qMw%3D%3D--%2BmQuRGPmuVsvAThS--hUkpzFQhJ31cVySNzxhpbg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.514432730.1766828007; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 09:33:27 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 09:33:27 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B136:21D903:41ED9EF:4F61B7B:694FA7E7
Add feature to disable JIT support in mozjs at compile-time by jschwe · Pull Request #37972 · servo/servo · GitHub
Copy link
Copy link
Copy link
Copy link
jschwe
force-pushed
the
bump_mozjs_optional_jit
branch
from
November 20, 2025 10:58
Copy link
Copy link
Copy link
jschwe
force-pushed
the
bump_mozjs_optional_jit
branch
from
November 20, 2025 11:46
Copy link
Copy link
Copy link
jschwe
added
T-full
Do a full try run
and removed
P-ohos
Any version of OpenHarmony
labels
Nov 20, 2025
Copy link
Copy link
Copy link
Copy link
servo-highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 20, 2025
Copy link
Copy link
Copy link
Copy link
Copy link
jschwe
force-pushed
the
bump_mozjs_optional_jit
branch
from
November 21, 2025 05:42
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
servo-highfive
removed
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 21, 2025
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 21, 2025
servo-highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 21, 2025
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add feature to disable JIT support in mozjs at compile-time #37972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
commented
Jul 10, 2025
ports/servoshell/Cargo.toml
Outdated
| [features] | ||
| crown = ["libservo/crown"] | ||
| debugmozjs = ["libservo/debugmozjs"] | ||
| default = ["max_log_level", "webgpu", "webxr"] |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging, the jit feature should be added to the default features of servoshell (perhaps even libservo).
Currently disabled to make sure everything works as expected with the feature off.
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that defaulting to enabled for libservo is the right call.
|
🔨 Triggering try run (#16185098266) for OpenHarmony |
|
✨ Try run (#16185098266) succeeded. |
jschwe
force-pushed
the
bump_mozjs_optional_jit
branch
from
2ac1b9a to
8d743d5
Compare
|
🔨 Triggering try run (#19534538460) for OpenHarmony |
|
✨ Try run (#19534538460) succeeded. |
|
🔨 Triggering try run (#19535631878) for Linux (Unit Tests, Build libservo, WPT, Bencher), Windows (Unit Tests, Build libservo), Android, OpenHarmony, Lint |
jschwe
force-pushed
the
bump_mozjs_optional_jit
branch
from
8d743d5 to
f54a21f
Compare
Bencher Report
|
Test results for linux-wpt from try job (#19535631878): Flaky unexpected result (30)
Stable unexpected results that are known to be intermittent (24)
|
|
|
jschwe
added
T-full
|
🔨 Triggering try run (#19541435116) for Linux (Unit Tests, Build libservo, WPT, Bencher), Windows (Unit Tests, Build libservo), Android, OpenHarmony, Lint |
|
| Branch | 37972/PR |
| Testbed | HUAWEI Mate 60 Pro |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Data | Measure (units) x 1e3 | Latency | milliseconds (ms) | Memory | Bytes | score | Measure (units) |
|---|---|---|---|---|---|---|---|---|
| release/E2E/file:///parse_from_string.html/ | 📈 view plot | 1.69 units x 1e3 | ||||||
| release/E2E/https://www.google.com/JS/gc-heap/admin | 📈 view plot | 26,752.00 | ||||||
| release/E2E/https://www.google.com/JS/gc-heap/decommitted | 📈 view plot | 409,600.00 | ||||||
| release/E2E/https://www.google.com/JS/gc-heap/unused | 📈 view plot | 136,016.00 | ||||||
| release/E2E/https://www.google.com/JS/gc-heap/used | 📈 view plot | 476,208.00 | ||||||
| release/E2E/https://www.google.com/JS/malloc-heap | 📈 view plot | 5,053,319.00 | ||||||
| release/E2E/https://www.google.com/JS/non-heap | 📈 view plot | 262,144.00 | ||||||
| release/E2E/https://www.google.com/LayoutThread/box-tree | 📈 view plot | 108,771.00 | ||||||
| release/E2E/https://www.google.com/LayoutThread/display-list | 📈 view plot | 0.00 | ||||||
| release/E2E/https://www.google.com/LayoutThread/font-context | 📈 view plot | 8,616.00 | ||||||
| release/E2E/https://www.google.com/LayoutThread/fragment-tree | 📈 view plot | 112.00 | ||||||
| release/E2E/https://www.google.com/LayoutThread/stacking-context-tree | 📈 view plot | 14,080.00 | ||||||
| release/E2E/https://www.google.com/LayoutThread/stylist | 📈 view plot | 5,504.00 | ||||||
| release/E2E/https://www.google.com/Load | 📈 view plot | 634.00 ms | ||||||
| release/E2E/https://www.google.com/Resident | 📈 view plot | 184,296,243.00 | ||||||
| release/E2E/https://www.google.com/image-cache | 📈 view plot | 2,328.00 | ||||||
| release/E2E/https://www.google.com/resident-smaps | 📈 view plot | 187,169,996.00 | ||||||
| release/E2E/https://www.servo.org/Load | 📈 view plot | 965.41 ms | ||||||
| release/E2E/https://www.servo.org/Resident | 📈 view plot | 365,160,857.00 | ||||||
| release/E2E/https://www.servo.org/resident-smaps | 📈 view plot | 368,122,265.00 | ||||||
| release/Speedometer/Charts-observable-plot | 📈 view plot | 712.54 ms | ||||||
| release/Speedometer/Charts-observable-plot/Dotted | 📈 view plot | 87.75 ms | ||||||
| release/Speedometer/Charts-observable-plot/Dotted/Async | 📈 view plot | 10.60 ms | ||||||
| release/Speedometer/Charts-observable-plot/Dotted/Sync | 📈 view plot | 77.15 ms | ||||||
| release/Speedometer/Charts-observable-plot/Stacked by 20 | 📈 view plot | 349.36 ms | ||||||
| release/Speedometer/Charts-observable-plot/Stacked by 20/Async | 📈 view plot | 17.79 ms | ||||||
| release/Speedometer/Charts-observable-plot/Stacked by 20/Sync | 📈 view plot | 331.57 ms | ||||||
| release/Speedometer/Charts-observable-plot/Stacked by 6 | 📈 view plot | 275.43 ms | ||||||
| release/Speedometer/Charts-observable-plot/Stacked by 6/Async | 📈 view plot | 9.12 ms | ||||||
| release/Speedometer/Charts-observable-plot/Stacked by 6/Sync | 📈 view plot | 266.32 ms | ||||||
| release/Speedometer/Geomean | 📈 view plot | 625.07 ms | ||||||
| release/Speedometer/Iteration-0-Total | 📈 view plot | 802.22 ms | ||||||
| release/Speedometer/Iteration-1-Total | 📈 view plot | 790.45 ms | ||||||
| release/Speedometer/Iteration-2-Total | 📈 view plot | 788.35 ms | ||||||
| release/Speedometer/Iteration-3-Total | 📈 view plot | 783.61 ms | ||||||
| release/Speedometer/Iteration-4-Total | 📈 view plot | 794.18 ms | ||||||
| release/Speedometer/Iteration-5-Total | 📈 view plot | 793.31 ms | ||||||
| release/Speedometer/Iteration-6-Total | 📈 view plot | 792.62 ms | ||||||
| release/Speedometer/Iteration-7-Total | 📈 view plot | 1,015.44 ms | ||||||
| release/Speedometer/Iteration-8-Total | 📈 view plot | 1,042.66 ms | ||||||
| release/Speedometer/Iteration-9-Total | 📈 view plot | 1,042.04 ms | ||||||
| release/Speedometer/Score | 📈 view plot | 1.62 units | ||||||
| release/Speedometer/TodoMVC-Angular | 📈 view plot | 870.94 ms | ||||||
| release/Speedometer/TodoMVC-Angular/Adding100Items | 📈 view plot | 418.80 ms | ||||||
| release/Speedometer/TodoMVC-Angular/Adding100Items/Async | 📈 view plot | 28.18 ms | ||||||
| release/Speedometer/TodoMVC-Angular/Adding100Items/Sync | 📈 view plot | 390.62 ms | ||||||
| release/Speedometer/TodoMVC-Angular/CompletingAllItems | 📈 view plot | 276.61 ms | ||||||
| release/Speedometer/TodoMVC-Angular/CompletingAllItems/Async | 📈 view plot | 31.37 ms | ||||||
| release/Speedometer/TodoMVC-Angular/CompletingAllItems/Sync | 📈 view plot | 245.23 ms | ||||||
| release/Speedometer/TodoMVC-Angular/DeletingAllItems | 📈 view plot | 175.53 ms | ||||||
| release/Speedometer/TodoMVC-Angular/DeletingAllItems/Async | 📈 view plot | 6.87 ms | ||||||
| release/Speedometer/TodoMVC-Angular/DeletingAllItems/Sync | 📈 view plot | 168.66 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES5 | 📈 view plot | 1,334.34 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES5/Adding100Items | 📈 view plot | 1,081.49 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES5/Adding100Items/Async | 📈 view plot | 46.67 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES5/Adding100Items/Sync | 📈 view plot | 1,034.82 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES5/CompletingAllItems | 📈 view plot | 159.70 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES5/CompletingAllItems/Async | 📈 view plot | 31.80 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES5/CompletingAllItems/Sync | 📈 view plot | 127.91 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES5/DeletingAllItems | 📈 view plot | 93.15 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES5/DeletingAllItems/Async | 📈 view plot | 7.23 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES5/DeletingAllItems/Sync | 📈 view plot | 85.91 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES6-Webpack | 📈 view plot | 1,927.70 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/Adding100Items | 📈 view plot | 1,554.12 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/Adding100Items/Async | 📈 view plot | 32.64 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/Adding100Items/Sync | 📈 view plot | 1,521.48 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/CompletingAllItems | 📈 view plot | 235.84 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/CompletingAllItems/Async | 📈 view plot | 37.30 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/CompletingAllItems/Sync | 📈 view plot | 198.55 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/DeletingAllItems | 📈 view plot | 137.74 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/DeletingAllItems/Async | 📈 view plot | 7.98 ms | ||||||
| release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/DeletingAllItems/Sync | 📈 view plot | 129.76 ms | ||||||
| release/Speedometer/TodoMVC-Preact | 📈 view plot | 147.53 ms | ||||||
| release/Speedometer/TodoMVC-Preact/Adding100Items | 📈 view plot | 74.54 ms | ||||||
| release/Speedometer/TodoMVC-Preact/Adding100Items/Async | 📈 view plot | 67.51 ms | ||||||
| release/Speedometer/TodoMVC-Preact/Adding100Items/Sync | 📈 view plot | 7.03 ms | ||||||
| release/Speedometer/TodoMVC-Preact/CompletingAllItems | 📈 view plot | 58.45 ms | ||||||
| release/Speedometer/TodoMVC-Preact/CompletingAllItems/Async | 📈 view plot | 47.17 ms | ||||||
| release/Speedometer/TodoMVC-Preact/CompletingAllItems/Sync | 📈 view plot | 11.28 ms | ||||||
| release/Speedometer/TodoMVC-Preact/DeletingAllItems | 📈 view plot | 14.54 ms | ||||||
| release/Speedometer/TodoMVC-Preact/DeletingAllItems/Async | 📈 view plot | 9.30 ms | ||||||
| release/Speedometer/TodoMVC-Preact/DeletingAllItems/Sync | 📈 view plot | 5.24 ms | ||||||
| release/Speedometer/TodoMVC-React | 📈 view plot | 812.77 ms | ||||||
| release/Speedometer/TodoMVC-React-Redux | 📈 view plot | 984.48 ms | ||||||
| release/Speedometer/TodoMVC-React-Redux/Adding100Items | 📈 view plot | 324.47 ms | ||||||
| release/Speedometer/TodoMVC-React-Redux/Adding100Items/Async | 📈 view plot | 33.64 ms | ||||||
| release/Speedometer/TodoMVC-React-Redux/Adding100Items/Sync | 📈 view plot | 290.83 ms | ||||||
| release/Speedometer/TodoMVC-React-Redux/CompletingAllItems | 📈 view plot | 430.73 ms | ||||||
| release/Speedometer/TodoMVC-React-Redux/CompletingAllItems/Async | 📈 view plot | 35.60 ms | ||||||
| release/Speedometer/TodoMVC-React-Redux/CompletingAllItems/Sync | 📈 view plot | 395.13 ms | ||||||
| release/Speedometer/TodoMVC-React-Redux/DeletingAllItems | 📈 view plot | 229.28 ms | ||||||
| release/Speedometer/TodoMVC-React-Redux/DeletingAllItems/Async | 📈 view plot | 7.24 ms | ||||||
| release/Speedometer/TodoMVC-React-Redux/DeletingAllItems/Sync | 📈 view plot | 222.04 ms | ||||||
| release/Speedometer/TodoMVC-React/Adding100Items | 📈 view plot | 289.91 ms | ||||||
| release/Speedometer/TodoMVC-React/Adding100Items/Async | 📈 view plot | 36.14 ms | ||||||
| release/Speedometer/TodoMVC-React/Adding100Items/Sync | 📈 view plot | 253.77 ms | ||||||
| release/Speedometer/TodoMVC-React/CompletingAllItems | 📈 view plot | 333.07 ms | ||||||
| release/Speedometer/TodoMVC-React/CompletingAllItems/Async | 📈 view plot | 34.94 ms | ||||||
| release/Speedometer/TodoMVC-React/CompletingAllItems/Sync | 📈 view plot | 298.13 ms | ||||||
| release/Speedometer/TodoMVC-React/DeletingAllItems | 📈 view plot | 189.80 ms | ||||||
| release/Speedometer/TodoMVC-React/DeletingAllItems/Async | 📈 view plot | 7.88 ms | ||||||
| release/Speedometer/TodoMVC-React/DeletingAllItems/Sync | 📈 view plot | 181.92 ms | ||||||
| release/Speedometer/TodoMVC-Svelte | 📈 view plot | 125.61 ms | ||||||
| release/Speedometer/TodoMVC-Svelte/Adding100Items | 📈 view plot | 70.19 ms | ||||||
| release/Speedometer/TodoMVC-Svelte/Adding100Items/Async | 📈 view plot | 54.14 ms | ||||||
| release/Speedometer/TodoMVC-Svelte/Adding100Items/Sync | 📈 view plot | 16.06 ms | ||||||
| release/Speedometer/TodoMVC-Svelte/CompletingAllItems | 📈 view plot | 41.65 ms | ||||||
| release/Speedometer/TodoMVC-Svelte/CompletingAllItems/Async | 📈 view plot | 33.83 ms | ||||||
| release/Speedometer/TodoMVC-Svelte/CompletingAllItems/Sync | 📈 view plot | 7.82 ms | ||||||
| release/Speedometer/TodoMVC-Svelte/DeletingAllItems | 📈 view plot | 13.76 ms | ||||||
| release/Speedometer/TodoMVC-Svelte/DeletingAllItems/Async | 📈 view plot | 9.71 ms | ||||||
| release/Speedometer/TodoMVC-Svelte/DeletingAllItems/Sync | 📈 view plot | 4.05 ms |
|
Test results for linux-wpt from try job (#19541435116): Flaky unexpected result (26)
Stable unexpected results that are known to be intermittent (26)
|
|
|
servo-highfive
added
the
S-awaiting-review
|
🔨 Triggering try run (#19547551310) for Linux (Unit Tests, Build libservo, WPT, Bencher), Windows (Unit Tests, Build libservo), Android, OpenHarmony, Lint |
|
Test results for linux-wpt from try job (#19547551310): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (20)
|
|
|
Member
Author
|
Currently blocked on the mozjs release workflow finishing, which has failed already a couple times due to intermittent errors when downloading dependencies (llvm) |
|
🔨 Triggering try run (#19560838506) for Linux (Unit Tests, Build libservo, WPT, Bencher), Windows (Unit Tests, Build libservo), Android, OpenHarmony, Lint |
This reduces the binary size from 89 to 80 MiB for linux production-stripped. By default we still enable JIT, but in scenarios where JIT is not required or not allowed by the system, the size savings make a feature worthwhile Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
force-pushed
the
bump_mozjs_optional_jit
branch
from
e3dc044 to
28c139e
Compare
|
Test results for linux-wpt from try job (#19560838506): Flaky unexpected result (38)
Stable unexpected results that are known to be intermittent (23)
|
|
✨ Try run (#19560838506) succeeded. |
sagudev
reviewed
Nov 21, 2025
ports/servoshell/Cargo.toml
Outdated
|
|
||
| [features] | ||
| default = ["max_log_level", "webgpu", "webxr"] | ||
| default = ["libservo/clipboard", "js_jit", "max_log_level", "webgpu", "webxr", "libservo/vello_cpu"] |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already enable vello_cpu down at libservo fetures, should we do the same for clipboard?
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reasoning here is that without vello-cpu, --no-default-features results in a compilation failure (since you need either vello or vello-cpu. I'm not sure yet what the best solution here is (besides a more helpful error message), but I think for now its the easiest to just unconditionally enable vello_cpu, without an option to disable it.
Servo compiles just fine without clipboard, so I think it makes sense to offer the option to disable it.
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, but we should not need vello_cpu here because it's already specified down there unconditionally.
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, removed vello_cpu from default-features as suggested. It's a bit wierd, since we already have a vello-cpu feature in servoshell, which is useless (and was useless before too), but we can resolve that separately.
sagudev
reviewed
Nov 21, 2025
|
|
||
| [features] | ||
| default = ["clipboard", "vello_cpu"] | ||
| default = ["clipboard", "js_jit", "vello_cpu"] |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to write comment that one need to duplicate this in servoshell.
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Probably we should start documenting the feature flags of libservo in general (opened an issue to not forget)
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
We anyway already enable vello_cpu via libservo Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
sagudev
approved these changes
Nov 21, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
When the
js_jitfeature is not selected, this reduces the binary size from 89 to 80 MiB for linux production-stripped.By default, we still enable JIT, but in scenarios where JIT is not required or not allowed by the system, the size savings make a feature worthwhile.
To allow disabling the feature,
servoshellnow depends on libservo withno-default-features, and hence gains explicit default features, that were previously enabled via libservos default features. To avoid compile-errors with--no-default-features,vello-cpuis unconditionally selected by servoshell (identical to previous behavior).Testing: The default behavior is unchanged. The HarmonyOS CI job does test with
--no-default-features