| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 29 Dec 2025 02:32:51 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=317.120976,conversation_content-fragment;desc="conversation_content fragment";dur=1034.602315,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=331.421647,nginx;desc="NGINX";dur=1.31764,glb;desc="GLB";dur=97.147628
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=J%2BxkyYLpRKxfbpBzO6ibG4Kf3I1jSkeP9VSLH38vvNqzFv0YkqMwmKiWc8igxErCygYYI9gSvJptfgoSJ1Nw7OSZholV4R9NNhN0PSw3M0Uyf5GMmjsiYww1hXMMwE8sVtbcGqcv3SjIusMa7afBSmLr5jIg3ONpT1vnXX4g1yLXSOo4cTcm0R4YeLpb%2Fr5Xp92mFNJOKK5DuRo0Qdo0AAMsFwG3QiyiI%2FKHZUg3rUfGOIcgreN5Lr%2BmLxX6LE4tVPDzxWyoGNmXy8cnjvQO9g%3D%3D--jFlikRH0LsYb5KYC--Lleu6cWExOyP6yuOjWDy0w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.280219603.1766975570; Path=/; Domain=github.com; Expires=Tue, 29 Dec 2026 02:32:50 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 29 Dec 2026 02:32:50 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D3BE:446F3:569E64F:68E7051:6951E852
Support `calc()` values in CSS Grid by nicoburns · Pull Request #34846 · servo/servo · GitHub
Support
Copy link
nicoburns
force-pushed
the
calc
branch
2 times, most recently
from
January 7, 2025 01:45
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
servo-highfive
removed
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 14, 2025
servo-highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Nov 14, 2025
Copy link
Copy link
Copy link
Copy link
Copy link
servo-highfive
added
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 14, 2025
servo-highfive
removed
the
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
label
Nov 14, 2025
Copy link
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Support calc() values in CSS Grid
#34846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#12631753246) for Linux WPT |
nicoburns
force-pushed
the
calc
branch
2 times, most recently
from
b136316 to
320c9ff
Compare
|
🔨 Triggering try run (#12643671693) for Linux WPT |
|
🔨 Triggering try run (#12643817737) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#12643817737): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (6)
|
|
|
|
🔨 Triggering try run (#12680825926) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#12680825926): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (8)
Stable unexpected results (5)
|
|
|
|
🔨 Triggering try run (#12681297721) for Linux WPT |
|
🔨 Triggering try run (#12681370403) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#12681370403): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (12)
|
|
✨ Try run (#12681370403) succeeded. |
Contributor
|
Based on the number of issues that are referring to this PR and the apparent websites that would visually look okay, this seems like a high value PR to me. I understand that it is blocked on the |
Signed-off-by: Nico Burns <nico@nicoburns.com>
Contributor
Author
|
My proposal would simply be to merge it as-is. Perhaps with some clarification to the SAFETY comment on the The comment at #34846 (comment) is still relevant. It is theoretically possible to make the Taffy API safe, and long-term I think it makes sense to make that happen (esp. as some similar changes would help with enabling parallel layout in Taffy). But it's a large piece of work (I'd estimate at least a couple of weeks, with risk of more if the initial versions causes performance regressions) for something that is a pure refactor (no additional functionality would be enabled), and I can't justify spending my time on that in the short term. If someone else wants to look it I can point them in the right direction. Finishing off DioxusLabs/taffy#855 would likely be the first piece. |
|
🔨 Triggering try run (#19377414882) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19377414882): Flaky unexpected result (41)
Stable unexpected results that are known to be intermittent (33)
Stable unexpected results (5)
|
|
|
Member
Seems reasonable. I will try to review soon. |
mrobinson
approved these changes
Nov 14, 2025
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Nico Burns <nico@nicoburns.com>
servo-highfive
added
the
S-awaiting-review
Contributor
Author
|
The failing subtest is for |
|
🔨 Triggering try run (#19378334520) for Linux (WPT) |
Contributor
Author
That was very soon! |
|
Test results for linux-wpt from try job (#19378334520): Flaky unexpected result (39)
Stable unexpected results that are known to be intermittent (29)
|
|
✨ Try run (#19378334520) succeeded. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Contributor
|
That was a lot quicker than I had expected. Glad to see this land, thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Depends on:
calc()integration stylo#104In addition to that a
resolve_calc_valuefunction has been added which resolves calc values during the layout process once a percentage resolution basis is available.There is 1 newly failing test and 1 newly failing subtest here.These issues have now been fixed.There are 8 new subtest failures in
css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html. These are genuine failures, but are unrelated to the calc implementation. The calc implementation is just exposing a pre-existing bug around percentage resolution that also now correctly also applies tocalc()values containing percentages. The fix for would best be done in a followup as it requires teaching Taffy about "compressible replaced elements". (update: I have this implemented but in the interest of keeping it to one feature per PR I have not included it here)./mach build -ddoes not report any errors./mach test-tidydoes not report any errors. It doesn't like the git dependency on Taffy.