You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo doesn't fetch metadata for sysroot, only we do.
Once we tried to fetch sysroot metadata within the cwd but it resulted in applying some not-wanted configs to sysroot metadata like in #20250
I'm not sure which one is grater, the number of configs should applied to sysroot likewise in the project cwd, or the number of configs that shouldn't applied to the sysroot. But for something like the above issue, there aren't much thing the user can do to avoid the issue, so I chose not running cargo metadata for sysroot in cwd.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21255
Hopefully this is the last thing that messes up our sysroot metadata fetch 😅