| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 27 Dec 2025 23:07:29 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=312.850563,conversation_content-fragment;desc="conversation_content fragment";dur=1257.62064,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=281.743429,nginx;desc="NGINX";dur=1.398994,glb;desc="GLB";dur=96.348932
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=zCGUTSs1wOX81OJS0Wq6ZTBHJQpNDFM1WbpUxFt8fxYRM4e8UHTlPsCZCQpVb4PtXC%2BjRPnEViTPSw5NaD1tF48G6Y1s3lFIxT2OGD4RG9BzU5AT4BA7sUESnUi6urhpF3zLZ6icUf7eAIU%2FKCtnRwIIr8l7Rwd0rt5WFlA1Zap15bwFFRNC8v2qZvDRfaWiIsJfnpChwjcszJSFhTh2M2SRQSkzC%2FcLHMVSC8MSBwVQal9XYb1pDAjcAYrWklDJsp6lY2uxmrNRtTZmRKjpbQ%3D%3D--%2FKomnXdLPV5uNHda--5wUCE69qzJYidejpYuj%2Brg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.967303347.1766876848; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 23:07:28 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 23:07:28 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CBCE:382597:494FD1E:58739BF:695066B0
perf: Use one query per crate for lang items, not one per lang item by ChayimFriedman2 · Pull Request #21149 · rust-lang/rust-analyzer · GitHub
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 28, 2025
Copy link
ChayimFriedman2
force-pushed
the
lang-items
branch
2 times, most recently
from
November 28, 2025 00:56
ChayimFriedman2
force-pushed
the
lang-items
branch
from
November 28, 2025 01:28
Copy link
Copy link
Copy link
rustbot
removed
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 29, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
perf: Use one query per crate for lang items, not one per lang item #21149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Via separate methods. This is both more clear, shorter, and will be required for the next commit.
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
commented
Nov 28, 2025
| } | ||
| "#, | ||
| expect![[r#" | ||
| me random_method(…) (use dep::test_mod::TestTrait) fn(&self) DEPRECATED |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do something about this test, the order changes every now and then.
ChayimFriedman2
force-pushed
the
lang-items
branch
2 times, most recently
from
24c68f5 to
d3d0845
Compare
Lang items rarely change, so putting a query for each doesn't give us anything. On the other hand, putting them behind only one query not only saves memory, it also has a giant benefit: we can store the struct with all lang items in the interner, making access to them very cheap. That basically means that anything in the hot path can avoid a *very common* query, and exchange it for a simple field access.
ChayimFriedman2
force-pushed
the
lang-items
branch
from
d3d0845 to
d9bee82
Compare
Contributor
Author
|
So I checked and this saves 7mb. Cute. Speed impact is more real. (However thinking about it it's amusing: those 7mb were likely caused, almost all of them, only by query dependencies!) |
Veykril
reviewed
Nov 29, 2025
| /// Salsa query. This will look for lang items in a specific crate. | ||
| #[salsa_macros::tracked(returns(ref))] | ||
| pub fn crate_lang_items(db: &dyn DefDatabase, krate: Crate) -> Option<Box<LangItems>> { | ||
| pub fn crate_lang_items(db: &dyn DefDatabase, krate: Crate) -> LangItems { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep the Option<Box<_>> here, 99.9% of all crates will have this by completely empty after all, unlike the lang_items query
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't really matter and makes the code a tad more complicated, having few extra kilobytes per crate won't matter for memory usage.
Veykril
approved these changes
Nov 29, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Lang items rarely change, so putting a query for each doesn't give us anything. On the other hand, putting them behind only one query not only saves memory, it also has a giant benefit: we can store the struct with all lang items in the interner, making access to them very cheap. That basically means that anything in the hot path can avoid a very common query, and exchange it for a simple field access.
This saves 3 seconds on analysis-stats on self. I can't measure the impact on memory as it fluctuates wildly due to some recent changes, but I believe the impact will be positive, and definitely not negative.
Reviewing commit-by-commit is recommended. The first commit is more technical and could use a skim review.