| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 27 Dec 2025 07:18:13 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=455.407852,conversation_content-fragment;desc="conversation_content fragment";dur=1551.351788,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=386.983528,nginx;desc="NGINX";dur=0.646179,glb;desc="GLB";dur=96.856241
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=zGvOij47ZhH39qbZNb1d67tSgOb2f44a78RWoxZGFy3Y1M8rNEf7kmZxQsJ7jIqFw%2F2aM5lnmGPo1O4XVeGsrmdWXnvclubo%2BeCL3QH5C2B%2BJnyS3yRBopo6%2BfSthYT75EFKKYPAExvYUZKQlyX3GHxR069bjmFj4TQUg8aWNhefoH1ZgfMjqSa2Odr3jctYs8hrUiDOhR2rdPyGi3OoB5D%2FqtAOv%2FiQbG8MMbJiA02GpkeX36YAIQclRC5D6PlZQem11mKbBfkFKIZB3gfMNQ%3D%3D--lZP1Y431nSXJFNNq--nCdDcnF%2BkXVKBV1Ik2tCcA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.192424294.1766819891; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 07:18:11 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 07:18:11 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8B30:382597:40E4990:4E33793:694F8833
fix Display scope inlay hints after closing brace for more types of blocks #18833 by asukaminato0721 · Pull Request #21077 · rust-lang/rust-analyzer · GitHub
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 20, 2025
rustbot
removed
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 20, 2025
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 20, 2025
Copy link
asukaminato0721
force-pushed
the
18833
branch
from
November 28, 2025 08:00
Copy link
Copy link
asukaminato0721
force-pushed
the
18833
branch
from
November 28, 2025 09:24
Copy link
Copy link
Copy link
Copy link
Copy link
asukaminato0721
force-pushed
the
18833
branch
from
November 28, 2025 11:12
Copy link
rustbot
removed
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 28, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix Display scope inlay hints after closing brace for more types of blocks #18833 #21077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
Nov 28, 2025
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few comments.
asukaminato0721
force-pushed
the
18833
branch
from
c2db0bb to
cc43651
Compare
ChayimFriedman2
requested changes
Nov 28, 2025
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments.
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if this is a false suspect, but: are you forwarding my comments to a LLM?
Anyway, please squash.
asukaminato0721
force-pushed
the
18833
branch
from
ef86808 to
8ff0403
Compare
ChayimFriedman2
approved these changes
Nov 28, 2025
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Contributor
Author
|
Contributor
|
We can definitely increase the MSRV, Rust 1.91.0 is already a month old. I'll send a PR immediately. |
Contributor
Author
|
CI failed on macOS syntax_highlighting::tests::syntax_highlighting_not_quadratic |
Member
|
That test looks flaky 🤔 |
auto-merge was automatically disabled
November 28, 2025 11:12
Head branch was pushed to by a user without write access
asukaminato0721
force-pushed
the
18833
branch
from
8ff0403 to
03cf272
Compare
Contributor
Author
|
rebase to fix clippy |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
fix #18833
Extended the closing-brace hint matcher to recognize MatchArmList nodes and many more BlockExpr parents (loops/while let/for/if+else/let else/match arms) while also prefixing function labels with qualifiers such as async/const/unsafe.
Added reusable helpers for qualifier formatting, trimmed snippet extraction with sane defaults, and label builders for for, if,
let else, match/arms so new scopes produce concise, truncated captions instead of raw syntax.Refreshed the test suite with an async fn coverage case plus a new expect_test that locks down the added block kinds and match-arm behavior, ensuring future regressions are caught without fighting //^ annotations.