| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 27 Dec 2025 09:54:11 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=389.188559,conversation_content-fragment;desc="conversation_content fragment";dur=576.901408,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=287.613471,nginx;desc="NGINX";dur=1.340768,glb;desc="GLB";dur=96.361653
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=r3i0qMROHnSp2dFEdTS2i%2FpJmU2UKtPKWglo7%2F6zz5iX6mTXtRRR9%2BLr%2B4nN0CA00Am6VUnq4NmUqyupuKS5u49pp8JrewFDnKyqCqaPCujnMJDKIJChqfZvpOgwfMSLQFXBh%2FVxg%2BEBVgxy%2BE3jaT7oaG1DAnvz%2BiiYcIK9e2auHNdWVvuC19L0SR6E7191w%2BiVQMU5GyG8TQvfkPO22wfjd3xJ%2Fe0g%2FkQJbgVYjLjnzL4I5aXXeJEFkB8SmEBnkbjNgHfdtpvB6jQ4XbFCxg%3D%3D--ikUzniwYWlJVBgkU--uOxHp8s3Jhfo7BrsxPLjbg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.521626722.1766829250; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 09:54:10 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 09:54:10 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DB7E:3654E1:422A461:4FADF4F:694FACC2
fix: Use per-token, not global, edition in the parser by ChayimFriedman2 · Pull Request #20163 · rust-lang/rust-analyzer · GitHub
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jul 3, 2025
ChayimFriedman2
force-pushed
the
parser-per-token-edition
branch
2 times, most recently
from
August 13, 2025 17:37
ChayimFriedman2
force-pushed
the
parser-per-token-edition
branch
from
August 13, 2025 17:37
Copy link
rustbot
removed
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 28, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: Use per-token, not global, edition in the parser #20163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Veykril
merged 2 commits into
rust-lang:master
from
ChayimFriedman2:parser-per-token-edition
Nov 28, 2025
Merged
fix: Use per-token, not global, edition in the parser #20163
Veykril
merged 2 commits into
rust-lang:master
from
ChayimFriedman2:parser-per-token-edition
Nov 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Because, as it turns out, this is necessary to determine the correct edition (it is not global). The next commits will make use of it.
ChayimFriedman2
force-pushed
the
parser-per-token-edition
branch
2 times, most recently
from
ed6ce36 to
5736fd3
Compare
ChayimFriedman2
force-pushed
the
parser-per-token-edition
branch
from
5736fd3 to
9bc940a
Compare
Veykril
reviewed
Nov 28, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really gotta rethink the entire parser infrastructure at some point. This input system is horrible and gets worse and worse over time. The edition vec is hugely wasteful for example (but likely the best we can do here)
Veykril
approved these changes
Nov 28, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This turns out to not mitigate #20153, because it was not the real reason. The real reason even has a FIXME:
rust-analyzer/crates/mbe/src/lib.rs
Lines 372 to 373 in 8b53dd0
But it still should fix some small bug that only appears on edition 2015. I didn't write a test because I'm not sure under what conditions it'll manifest, but it should be there.