| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 25 Dec 2025 21:11:03 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=428.065179,conversation_content-fragment;desc="conversation_content fragment";dur=646.130735,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=356.754114,nginx;desc="NGINX";dur=0.648921,glb;desc="GLB";dur=97.537854
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ZNEFxF4nlL7FKQu5SzpvP0pUnxKxEZ2I9Aw9WPjQtEhs35%2FhcYWNyFSkQY%2FvLUJzXnuqk2wrOXP5PbeFvMxJg4v9uRFo%2Fzr1oOw38sMcAYMCN7vfmt0yjQqNL4mF6H5yGmJqgU8U4s1VPZsifXKmoywlus4sph4SM2AgVrj2SgJ%2B%2FGnq2TyOgbF45JAlJuXtVRwdLGprkU0ynyIvAG14vvTHQzSI9jRd5qxBXI2zUpwz1cjjvdUptHGhiB9BKDhZWImON%2B6SfnJP3aRQ55grmA%3D%3D--gb7BO7%2FkU0kJFi32--bwOxiQZTB%2FUBabFQm5Q0Iw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.829647621.1766697062; Path=/; Domain=github.com; Expires=Fri, 25 Dec 2026 21:11:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 25 Dec 2026 21:11:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B202:268821:2F864D4:38D8F4D:694DA866
[java] Fix #4742: EmptyFinalizer should not trigger if finalize method is final and class is not by mrclmh · Pull Request #6255 · pmd/pmd · GitHub
Copy link
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[java] Fix #4742: EmptyFinalizer should not trigger if finalize method is final and class is not #6255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have some branch mixup I have to fix first. |
Add an exception to the EmptyFinalizer rule to avoid reporting an empty finalizer if it is marked as final in a non-final class. This is one possible security measure against finalizer attacks.
Contributor
Author
|
This could also be implemented as a union for both cases, which is less readable IMO. Are there any known peformance problems with ancestor backtracking? |
adangel
approved these changes
Nov 27, 2025
Member
adangel
left a comment
adangel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This could also be implemented as a union for both cases, which is less readable IMO. Are there any known peformance problems with ancestor backtracking?
Not sure. Let's keep it as is.
Contributor
|
Compared to main: (comment created at 2025-11-27 17:18:56+00:00 for 8aca999) |
adangel
added a commit
that referenced
this pull request
Nov 27, 2025
adangel
added a commit
that referenced
this pull request
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Describe the PR
This PR extends the EmptyFinalizer rule to not report an error if the
finalizemethod is marked asfinalin a non-final class. This is a one possible security measure against finalizer attacks.Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)