| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 25 Dec 2025 21:10:45 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=2204.335768,conversation_content-fragment;desc="conversation_content fragment";dur=892.939976,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=268.149599,nginx;desc="NGINX";dur=1.304779,glb;desc="GLB";dur=97.085731
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=QvfgV%2F6PGDjBlQ0qghfqnrhNcpQxwU6hi%2B6N%2B1O9iJELcDUKgb%2BsrWCavdMkk8TyO7CDy118dq%2BUgLb7LrlOwczpPels2qLSufguXi1mGCnrXFfIBzDWrA7eBnMyZQrku9flh7bpTpncwEE3FZJ9IoIYMuEtvjqQTr%2FoaHldfEQ1rJZ6OkvmYOL2QikhIyywLcZfMh%2FvczmGgJf0HTmzA9ZFb2jkwNbtZz6t0%2Fs3Qs45pjpuZJiZPAVdZrksriPrv3Ngq61TUuP8i%2BUURVbSfg%3D%3D--Lx7Hf3Sn%2BvOXWPcb--02XRtXeFqfVqLlETLLpt8Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1398019620.1766697042; Path=/; Domain=github.com; Expires=Fri, 25 Dec 2026 21:10:42 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 25 Dec 2026 21:10:42 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B3CE:2F8118:2F8B83F:38D6D25:694DA852
chore: remove public methods from SourceManager by adangel · Pull Request #6229 · pmd/pmd · GitHub
Copy link
Copy link
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: remove public methods from SourceManager #6229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adangel
merged 1 commit into
pmd:main
from
adangel:chore/issue-5701-SourceManager-public-methods
Nov 27, 2025
Merged
chore: remove public methods from SourceManager #6229
adangel
merged 1 commit into
pmd:main
from
adangel:chore/issue-5701-SourceManager-public-methods
Nov 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceManager itself is package-private, so the effective visibility of those methods won't be public anyway. Fixes pmd#5701
Contributor
|
Compared to main: (comment created at 2025-11-13 16:13:53+00:00 for 7764d1d) |
Member
Author
|
Note: This only fixes the instances in SourceManager. Running #6231 against PMD's codebase reveals a lot more instances (~ 100 in pmd-core). |
elharo
reviewed
Nov 15, 2025
| ### 🚀️ New and noteworthy | ||
|
|
||
| ### 🐛️ Fixed Issues | ||
| * general |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems purely internal. As a user, I wouldn't need to see this in the release notes
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, maybe we can move it down under "internal/maintenance", it's not important for users. But I'd like to have the release notes complete and match what we track with the milestone.
Member
Author
|
I'm going to merge this for 7.19.0, assuming this is ok. |
adangel
added a commit
that referenced
this pull request
Nov 27, 2025
adangel
added a commit
that referenced
this pull request
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Describe the PR
SourceManager itself is package-private, so the effective visibility of those methods won't be public anyway.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)