meta: reword linter messages

avivkeller · RafaelGSS · commit b312ec0b0c52 · 2024-08-05T11:15:41.000-03:00
PR-URL: #53949 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -346,31 +346,31 @@ export default [
       'error',
       {
         name: '__filename',
-        message: 'Use import.meta.url instead',
+        message: 'Use import.meta.url instead.',
       },
       {
         name: '__dirname',
-        message: 'Not available in ESM',
+        message: 'Not available in ESM.',
       },
       {
         name: 'exports',
-        message: 'Not available in ESM',
+        message: 'Not available in ESM.',
       },
       {
         name: 'module',
-        message: 'Not available in ESM',
+        message: 'Not available in ESM.',
       },
       {
         name: 'require',
-        message: 'Use import instead',
+        message: 'Use import instead.',
       },
       {
         name: 'Buffer',
-        message: 'Import Buffer instead of using the global',
+        message: "Import 'Buffer' instead of using the global.",
       },
       {
         name: 'process',
-        message: 'Import process instead of using the global',
+        message: "Import 'process' instead of using the global.",
       },
     ] },
   },
diff --git a/lib/eslint.config_partial.mjs b/lib/eslint.config_partial.mjs
@@ -11,23 +11,23 @@ const noRestrictedSyntax = [
   ...noRestrictedSyntaxCommonLib,
   {
     selector: "CallExpression[callee.object.name='assert']:not([callee.property.name='ok']):not([callee.property.name='fail']):not([callee.property.name='ifError'])",
-    message: 'Please only use simple assertions in ./lib',
+    message: 'Only use simple assertions',
   },
   {
     selector: 'NewExpression[callee.name=/Error$/]:not([callee.name=/^(AssertionError|NghttpError|AbortError|NodeAggregateError)$/])',
-    message: 'Use an error exported by the internal/errors module.',
+    message: "Use an error exported by 'internal/errors' instead.",
   },
   {
     selector: "CallExpression[callee.object.name='Error'][callee.property.name='captureStackTrace']",
-    message: "Please use `require('internal/errors').hideStackFrames()` instead.",
+    message: "Use 'hideStackFrames' from 'internal/errors' instead.",
   },
   {
     selector: "AssignmentExpression:matches([left.object.name='Error']):matches([left.name='prepareStackTrace'], [left.property.name='prepareStackTrace'])",
-    message: "Use 'overrideStackTrace' from 'lib/internal/errors.js' instead of 'Error.prepareStackTrace'.",
+    message: "Use 'overrideStackTrace' from 'internal/errors' instead.",
   },
   {
     selector: "ThrowStatement > NewExpression[callee.name=/^ERR_[A-Z_]+$/] > ObjectExpression:first-child:not(:has([key.name='message']):has([key.name='code']):has([key.name='syscall']))",
-    message: 'The context passed into SystemError constructor must have .code, .syscall and .message.',
+    message: 'The context passed into the SystemError constructor must include .code, .syscall, and .message properties.',
   },
 ];
 
@@ -500,7 +500,7 @@ export default [
         ...noRestrictedSyntax,
         {
           selector: 'VariableDeclarator:has(.init[name="primordials"]) Identifier[name=/Prototype[A-Z]/]:not([name=/^(Object|Reflect)(Get|Set)PrototypeOf$/])',
-          message: 'We do not use prototype primordials in this file',
+          message: 'Do not use prototype primordials in this file.',
         },
       ],
     },

Original file line number	Diff line number	Diff line change
`@@ -346,31 +346,31 @@ export default [`
`346`	`346`	`'error',`
`347`	`347`	`{`
`348`	`348`	`name: '__filename',`
`349`		`- message: 'Use import.meta.url instead',`
	`349`	`+ message: 'Use import.meta.url instead.',`
`350`	`350`	`},`
`351`	`351`	`{`
`352`	`352`	`name: '__dirname',`
`353`		`- message: 'Not available in ESM',`
	`353`	`+ message: 'Not available in ESM.',`
`354`	`354`	`},`
`355`	`355`	`{`
`356`	`356`	`name: 'exports',`
`357`		`- message: 'Not available in ESM',`
	`357`	`+ message: 'Not available in ESM.',`
`358`	`358`	`},`
`359`	`359`	`{`
`360`	`360`	`name: 'module',`
`361`		`- message: 'Not available in ESM',`
	`361`	`+ message: 'Not available in ESM.',`
`362`	`362`	`},`
`363`	`363`	`{`
`364`	`364`	`name: 'require',`
`365`		`- message: 'Use import instead',`
	`365`	`+ message: 'Use import instead.',`
`366`	`366`	`},`
`367`	`367`	`{`
`368`	`368`	`name: 'Buffer',`
`369`		`- message: 'Import Buffer instead of using the global',`
	`369`	`+ message: "Import 'Buffer' instead of using the global.",`
`370`	`370`	`},`
`371`	`371`	`{`
`372`	`372`	`name: 'process',`
`373`		`- message: 'Import process instead of using the global',`
	`373`	`+ message: "Import 'process' instead of using the global.",`
`374`	`374`	`},`
`375`	`375`	`] },`
`376`	`376`	`},`