build: avoid compiling with VS v17.10

huseyinacacak-janea · RafaelGSS · commit 7c417c6cf41f · 2024-08-05T11:15:44.000-03:00
Refs: nodejs/build#3739 PR-URL: #53863 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
diff --git a/vcbuild.bat b/vcbuild.bat
@@ -281,6 +281,14 @@ goto exit
 
 :msbuild-found
 
+@rem Visual Studio v17.10 has a bug that causes the build to fail.
+@rem Check if the version is v17.10 and exit if it is.
+echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
+if %errorlevel% neq 1  (
+  echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
+  goto exit
+)
+
 @rem check if the clang-cl build is requested
 if not defined clang_cl goto clang-skip
 @rem x64 is hard coded as it is used for both cross and native compilation.
