test_runner: added colors to dot reporter

Giovanni · RafaelGSS · commit 4887213f2e5e · 2024-08-05T11:15:43.000-03:00
PR-URL: #53450 Fixes: #51770 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/test_runner/reporter/dot.js b/lib/internal/test_runner/reporter/dot.js
@@ -12,10 +12,10 @@ module.exports = async function* dot(source) {
   const failedTests = [];
   for await (const { type, data } of source) {
     if (type === 'test:pass') {
-      yield '.';
+      yield `${colors.green}.${colors.clear}`;
     }
     if (type === 'test:fail') {
-      yield 'X';
+      yield `${colors.red}X${colors.clear}`;
       ArrayPrototypePush(failedTests, data);
     }
     if ((type === 'test:fail' || type === 'test:pass') && ++count === columns) {
diff --git a/test/fixtures/test-runner/output/dot_output_custom_columns.js b/test/fixtures/test-runner/output/dot_output_custom_columns.js
@@ -1,6 +1,9 @@
 // Flags: --test-reporter=dot
 'use strict';
 process.stdout.columns = 30;
+process.env.FORCE_COLOR = '1';
+delete process.env.NODE_DISABLE_COLORS;
+delete process.env.NO_COLOR;
 
 const test = require('node:test');
 const { setTimeout } = require('timers/promises');
diff --git a/test/fixtures/test-runner/output/dot_output_custom_columns.snapshot b/test/fixtures/test-runner/output/dot_output_custom_columns.snapshot
@@ -1,3 +1,3 @@
-..............................
-.........................................
-.............................
+[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c
+[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c
+[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c[32m.c

Original file line number	Diff line number	Diff line change
`@@ -12,10 +12,10 @@ module.exports = async function* dot(source) {`
`12`	`12`	`const failedTests = [];`
`13`	`13`	`for await (const { type, data } of source) {`
`14`	`14`	`if (type === 'test:pass') {`
`15`		`- yield '.';`
	`15`	+ yield `${colors.green}.${colors.clear}`;
`16`	`16`	`}`
`17`	`17`	`if (type === 'test:fail') {`
`18`		`- yield 'X';`
	`18`	+ yield `${colors.red}X${colors.clear}`;
`19`	`19`	`ArrayPrototypePush(failedTests, data);`
`20`	`20`	`}`
`21`	`21`	`if ((type === 'test:fail' \|\| type === 'test:pass') && ++count === columns) {`