You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameter arg[2] is not guaranteed to be valid while preforming INSTCMD.
Don't pass directly to main_instcmd().
Signed-off-by: Doug Nazar <nazard@nazar.ca>
The api for get_item_buffered() requires the actual error to be in errno
which was automatic for libusb 0.x but libusb 1.x doesn't use errno.
Otherwise a poll-only driver will miss errors like disconnects and never try
to reconnect.
Signed-off-by: Doug Nazar <nazard@nazar.ca>
jimklimov
added
bug
impacts-release-2.8.0
Issues reported against NUT release 2.8.0 (maybe vanilla or with minor packaging tweaks)
impacts-release-2.8.1
Issues reported against NUT release 2.8.1 (maybe vanilla or with minor packaging tweaks)
and removed
impacts-release-2.8.0
Issues reported against NUT release 2.8.0 (maybe vanilla or with minor packaging tweaks)
labels
Nov 9, 2023
Thanks! The SIGSEGV one seems like this-year's addition, so not a part of earlier releases and I suppose too few people ran the new code with actual commands to notice it :( and neither did static analyzers :\
I suppose this misfires with all single-token commands without an argument?
Out of curiosity, in what sort of workflow did you detect it?
bugimpacts-release-2.8.1Issues reported against NUT release 2.8.1 (maybe vanilla or with minor packaging tweaks)
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple small one-line fixes: