| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 28 Dec 2025 04:49:50 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=447.347935,conversation_content-fragment;desc="conversation_content fragment";dur=936.077756,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=382.079385,nginx;desc="NGINX";dur=1.434637,glb;desc="GLB";dur=97.280627
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=79KW39QzzOGJjADg3h%2FqsMx0axfAqF0oYp4tPoAtwQ7feDyuUIgBkaK3zhJAFKvu3jYaFDeTOfnOGQg7Rc4yD3nHo%2FlEaQr5LxaHqxmXkxZu2MVTPdS2J2acadZlDWHLkhuJM10xQZcKLFI%2BKubwLepOIsylZHErNHucK2zERiwkd2ffEtKtUBoVAH70wANovgKbyxNduzbxVdEIO%2FFHl%2BgZcih8SsHMYRLh7ZWFRfGy4IrFimI73uJbMlrZj2JUvXvqff9WjKFdske1ukwtTg%3D%3D--D%2BQcDHmvTI8OQ%2F%2Bo--SUYmFprdHw8GXJcC8cBoAQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2094052509.1766897389; Path=/; Domain=github.com; Expires=Mon, 28 Dec 2026 04:49:49 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 28 Dec 2026 04:49:49 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BBFC:2F8118:4B02159:5AC1AB4:6950B6ED
Fix assignment of intersections to objects with optional properties by ahejlsberg · Pull Request #37195 · microsoft/TypeScript · GitHub
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Fix assignment of intersections to objects with optional properties #37195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@typescript-bot test this |
Collaborator
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f902f8a. You can monitor the build here. |
Collaborator
|
Heya @ahejlsberg, I've started to run the perf test suite on this PR at f902f8a. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at f902f8a. You can monitor the build here. |
Collaborator
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at f902f8a. You can monitor the build here. |
Collaborator
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Collaborator
|
@ahejlsberg Here they are:Comparison Report - master..37195
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
@typescript-bot run dt |
Collaborator
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f902f8a. You can monitor the build here. |
Member
Author
|
@typescript-bot user test this |
Collaborator
|
Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 1a5911a. You can monitor the build here. |
Member
|
So, notably, this does not fix #36637 because that has a generic |
Member
Author
That's right. |
Collaborator
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Member
Author
|
@weswigham Can you take a look at the last user test suite run and tell me which of those are preexisting conditions, or how I might find out? The |
Member
Looking over #37219 and #37203 , looks like just the |
Member
Author
|
Summarizing test runs: No change in RWC and DT and no appreciable perf impact. New errors in the So, this PR is technically a breaking change because we find new issues. |
Member
|
@typescript-bot pack this |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 1a5911a. You can monitor the build here. |
Collaborator
|
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build. |
Member
|
CC @dzearing @JasonGore, it looks like this change will cause issues for Fabric. It looks like tightening the declarations of to use |
This was referenced Mar 13, 2020
This was referenced Mar 31, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
We consider any intersection
A & Bassignable to a typeTif eitherAorBis assignable toT. This can be problematic whenTis an object type with optional properties. For example:The issue here is that because
{ b: string }is assignable to{ a?: number, b: string }we also consider any intersection that includes{ b: string }to be assignable--even if the intersection includes another type that conflicts with the optionalaproperty.With this PR we now require intersections of object types as a whole to be assignable to the target type. In other words, we treat
{ a: null } & { b: string}identically to{ a: null, b: string }in relationships.Fixes #36604.