You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently diff between StringSwitchEcjFilter and KotlinWhenStringFilter is
26,27c26,27< * Filters code that is generated by ECJ for a <code>switch</code> statement< * with a <code>String</code>.---> * Filters bytecode that Kotlin compiler generates for <code>when</code>> * expressions with a <code>String</code>.29c29< public final class StringSwitchEcjFilter implements IFilter {---> public final class KotlinWhenStringFilter implements IFilter {46a47> nextIsVar(Opcodes.ALOAD, "s");73a75,77> // jump to next comparison or default case> nextIs(Opcodes.IFEQ);> final JumpInsnNode jump = (JumpInsnNode) cursor;75c79< nextIs(Opcodes.IFNE);---> nextIs(Opcodes.GOTO);83c87< if (cursor.getNext().getOpcode() == Opcodes.GOTO) {---> if (jump.label == defaultLabel) {85,86d88< // jump to default< nextIs(Opcodes.GOTO);
😆 but I'd like to propose and would really prefer to work on refactoring separately.
@marchof A quick random thought: instructionAfterLabel(LabelNode) compared to skipNonOpcodes(AbstractInsnNode) is safer since accepts only LabelNode. So let's go without skipNonOpcodes - will think about this at a time of thinking about similarity between StringSwitchEcjFilter and KotlinWhenStringFilter.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.