You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there are many other projects waiting JaCoCo release with upgraded ASM (#1965), we are postponing the only so far found unhandled remaining and not so easy to handle case of @kotlinx.serialization.Serializable#1971, and staged 0.8.14 to be released with this change as latest. CC @merks@iloveeclipse
@Dukoff92@ajeihala Even if we are very confident in absence of NPEs and in this change in general, would it be possible to test latest snapshot to check our theory that with this change even without #1971 situation is already much better than before, and there are no other remaining cases than #1971 ?
Thanks again for looking into the issue and providing a fix. I can confirm that everything looks good with the latest snapshot version. I’ve checked all sealed classes with the @Serializable annotation in our codebase, and I don’t see any generated methods in the report.
I also looked at the generated methods when data class parameters are of type List, and didn’t find any generated ones for those either.
We don’t have any enum classes using serialization, so I can’t speak to that, but I see that it’s been addressed in the PR above. Maybe @ajeihala can test it out and provide more clarity.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was overlooked in #1885
See #1969 (comment)
For example in case of
or
Example$Companion.get$cachedSerializer()Example$Companion.serializer()Example._init_$_anonymous_()- see JetBrains/kotlin@3f034e8In case of
Example.get$cachedSerializer()Example.serializer()And in case of
Example._childSerializers$_anonymous_()- see JetBrains/kotlin@3f034e8 and JetBrains/kotlin@b35161eExample._childSerializers$_anonymous_$0()