You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Then following this PR we probably want to update the two metagraph visualizations here. I made these with the macOS OmniGraffle program. Perhaps I could dust off the old machine to update them.
We were asked by a reviewer about the whether the Hetionet color palettes are color blind friendly, so I made the following figure using https://hclwizard.org:3000/cvdemulator/:
It's interesting to see how the colors appear based on different color vision deficiencies. Many of the colors are still differentiable. Also we often show the metanode name or abbreviation along with the colors, such that I don't think any action is needed, just something to consider.
I don't proclaim to be an expert in accessibility or color theory, but I think the best way to make something "color blind friendly" is to make it not rely on colors at all, as you said. Then colors can just be a bonus. I think there's only so much you can do when certain color blindnesses limit you to only ~3 hues, and we have 8 types here. A true expert in color accessibility could probably tweak the brightnesses and saturations and such to be slightly more differentiable, but probably not worthwhile enough to change all the code and figures. I believe I made sure to have text or initials everywhere we used these colors on the website and in connectivity search.
dhimmel
added a commit
to dhimmel/connectivity-search-manuscript
that referenced
this pull request
Mar 3, 2023
I believe I made sure to have text or initials everywhere we used these colors on the website and in connectivity search.
Yes. The visualizations would work without color at all, but would be less pretty.
Looking at the commits in this PR, I see 7417ce9 with message, "improve consistency and accessibility of metanode colors", so I'm inclined to think that accessibility was a criteria for your revisions.
dhimmel
added a commit
to greenelab/connectivity-search-manuscript
that referenced
this pull request
Mar 14, 2023
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
old:


new:
@dhimmel