You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently streaming endpoints are always returning 200 OK. With this it is not possible to implement e.g. Range Requests, as those need to return 206 Partial Content. This PR changes this.
How would I write a test for this? I guess I somehow have to assert the status code, but I am not sure how to get that status with clientM. I am only using servant-server myself
Currently streaming endpoints only return a ResultStream, there is no way to get the status code. Should I add a Status entry on the ResultStream type, in addition to the IO Continuation?
I'm not sure how you would want to handle this. I haven't had (and will not for at least this week) have time to look deeper into the servant-client code base to take a look how normal responses handle this.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently streaming endpoints are always returning
200 OK. With this it is not possible to implement e.g. Range Requests, as those need to return206 Partial Content. This PR changes this.