You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alpmestan looking across servant codebase, the import styles vary a lot, what worse even inside single file. As a contributor I'm always confused "now I have to add new module import, where and how should I put it". From that POV uniform style will help.
I'm not the huge fan of the style proposed, but it's one of diff friendly ones.
Another variant is to separate explicit import lists and qualified imports into two groups:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With one file formatted as an example.
AFAICS, this is only configuration where indentation/alignment won't change globally if you add/remove long module name or qualified imports.
One option would be to have short lists right after the module name, but there isn't such configuration option in
stylish-haskellatm.