| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 16 Jan 2026 03:18:53 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=319.236539,conversation_content-fragment;desc="conversation_content fragment";dur=517.240685,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=246.135129,nginx;desc="NGINX";dur=1.395312,glb;desc="GLB";dur=102.998397
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 69ef6d1
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=DSuONO5KWuVafTVX572PeH5QvFoGYol96NNPPzcQeO04tpQ30wNecOJrBUXYt6P287BzIUiNCUF1n%2FTYEH%2FFikie6oqxfhOdcElx9SdYOUWTJkCYsNgWT16eqD71NZH71Pa2WrVVQT2HKKQSbzbR4byADBxHdNIWpQkB2po38X6PXorcFNhlsZz9IJgI7TsDBt6EWy5PQDqPlL5ynb6%2B6XT2ITxiC6uKJacll%2BKmk2hm4vqNc3ugQ8HW%2BZyC8MjNAICs1KUxJbgZKG36OZNSZA%3D%3D--bVTqfcykPhluCC%2FG--QrTnUXqHpHgWlQdXCj%2FWOQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1113370487.1768533533; Path=/; Domain=github.com; Expires=Sat, 16 Jan 2027 03:18:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 16 Jan 2027 03:18:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AF70:D1D95:1F8F2D:2AB067:6969AE1D
[new-hs-indexer #9] Index types by simonmar · Pull Request #532 · facebookincubator/Glean · GitHub
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
May 30, 2025
Copy link
simonmar
force-pushed
the
hs-indexer-types
branch
from
May 30, 2025 16:18
Copy link
simonmar
force-pushed
the
hs-indexer-types
branch
2 times, most recently
from
June 8, 2025 07:19
simonmar
force-pushed
the
hs-indexer-types
branch
from
June 10, 2025 08:49
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 81
[new-hs-indexer #9] Index types #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
âś… Deploy Preview for fb-oss-glean canceled.
|
simonmar
force-pushed
the
hs-indexer-types
branch
from
eb00a3a to
edb1145
Compare
Contributor
|
@nhawkes has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
It's useful to be able to know whether a ref is in an import or export, e.g. for dead code detection, so let's tag refs with an enum to say what kind of ref it is. I changed field names so that the schema change shouldn't trigger a validation failure (I hope).
1. Ignore Names that come from another source file (TODO) 2. Ignore Names that come from the current source file but have a line number outside the valid range. No idea why this happens, I didn't investigate.
Mostly reconstructing sensible source file paths. See the comments. With this change I can index all of Hackage (2900+ packages).
We had name/parent swapped over in the Haskell instance for ToQName.
simonmar
force-pushed
the
hs-indexer-types
branch
2 times, most recently
from
9995dc2 to
2da654b
Compare
This adds types to ValBind, which provides type annotations through Glass for all variables including local variables.
simonmar
force-pushed
the
hs-indexer-types
branch
from
2da654b to
6c2f674
Compare
Contributor
|
@bochko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This adds types to ValBind, which provides type annotations through
Glass for all variables including local variables.