| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 26 Dec 2025 10:05:25 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=411.842659,conversation_content-fragment;desc="conversation_content fragment";dur=577.342685,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=284.608662,nginx;desc="NGINX";dur=1.473404,glb;desc="GLB";dur=97.241295
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2Bp3wcoJfB4IU9EPK00mxNxH4%2BWoOI%2F2JtGV5DwTHqfS%2BaHfmWWB9q%2Bznpu4H9%2Bu7FwTp7LJl%2BMoD%2FuHMyz13mqHXe4IXCXkuQjO9t37LKOw5fywY05HkH1A2ou1vL4%2FWSqWjMmGzJesJdueuk3liO6xwunF8gQQVJMp94%2BbQMHwSV7sbOOVRD1RmwzdhIKXF94%2F2YiqxImr5SGcmlAr8uk3yoY2vvoWw3%2BO4pZ5sBGNrme%2Bgefc8klbxCzJ%2BEqqEMFn4OdCqqSwyUOA1i1TF%2Fw%3D%3D--awPZYadskr4csl5t--Omzj%2Bvz3uFIQe1nmZBWnLg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.553400712.1766743524; Path=/; Domain=github.com; Expires=Sat, 26 Dec 2026 10:05:24 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 26 Dec 2026 10:05:24 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D000:3AC056:360C2D2:40D56D0:694E5DE4
Fix crash with guessing return type by vovkasm · Pull Request #364 · esdoc/esdoc · GitHub
Copy link
vovkasm
force-pushed
the
fix-crash-with-guessing-return-type
branch
from
January 1, 2017 20:58
Copy link
Copy link
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 200
Fix crash with guessing return type #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
h13i32maru
merged 4 commits into
esdoc:master
from
vovkasm:fix-crash-with-guessing-return-type
Jan 2, 2017
Merged
Fix crash with guessing return type #364
h13i32maru
merged 4 commits into
esdoc:master
from
vovkasm:fix-crash-with-guessing-return-type
Jan 2, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Anyone? (If it helps, I can rebase branch to latest master) |
esdoc try to guess function return type when not `@return` tag found. When return type is Object, most times it can determine it's shape from AST. But when this object contains rest spread operator, it became compicated (for ex `return { ...obj }`, theorethically we can try track deeper and determine shape of `obj`, but for now we simple break guessing with `*`). In any case, this commit fixed crash with this case, because when AST node contain object with type `SpreadProperty`, it of course has no `key`.
8cbcdd7 to
f187817
Compare
Contributor
Author
|
I just rebase and fixed this branch. |
Member
|
@vovkasm Sorry for late reply 🙇 |
Member
|
And I improved to guess object spread. Thanks. |
Contributor
Author
|
Cool! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Minimal sample to reproduce crash:
Esdoc try to guess function return type when not
@returntag found. When return type is Object, most times it can determine it's shape from AST. But when this object contains rest spread operator, it became compicated (for exreturn { ...obj }, theorethically we can try track deeper and determine shape ofobj, but for now we simple break guessing with*). In any case, this commit fixed crash with this case, because when AST node contain object with typeSpreadProperty, it of course has nokey.