You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issues which may arise when using a database implementation which doesn't construct $wpdb->queries in the same way as core does, namely when a logged query is not an indexed array or it it doesn't have a float at index 1. This can happen when using a custom save_query_callback in HyperDB, for example. This essentially builds upon the existing type checking for odd database implementations which don't define $wpdb->queries. In both cases, notices are now emitted before aborting.
If $wpdb->queries is absent or not an array, this notice is emitted:
perflab_register_default_server_timing_before_template_metrics(): Unable to compute server timing for "before-template-db-queries" because $wpdb->queries is not an array.
If a saved query array doesn't have the expected elapsed time as the second argument, then this notice is emitted:
perflab_register_default_server_timing_before_template_metrics(): Unable to compute server timing for "before-template-db-queries" because a saved query in $wpdb->queries lacks the elapsed time as the second array value.
Otherwise, if all is good, then the before-template-db-queries server timing entry is sent:
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
❌ Patch coverage is 2.50000% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.54%. Comparing base (01a0027) to head (4a8aa77). ⚠️ Report is 74 commits behind head on trunk.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2158
This addresses issues which may arise when using a database implementation which doesn't construct
$wpdb->queriesin the same way as core does, namely when a logged query is not an indexed array or it it doesn't have a float at index 1. This can happen when using a customsave_query_callbackin HyperDB, for example. This essentially builds upon the existing type checking for odd database implementations which don't define$wpdb->queries. In both cases, notices are now emitted before aborting.If
$wpdb->queriesis absent or not an array, this notice is emitted:If a saved query array doesn't have the expected elapsed time as the second argument, then this notice is emitted:
Otherwise, if all is good, then the
before-template-db-queriesserver timing entry is sent: