| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 27 Dec 2025 02:25:14 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=454.06952,conversation_content-fragment;desc="conversation_content fragment";dur=579.278705,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=303.190889,nginx;desc="NGINX";dur=0.691476,glb;desc="GLB";dur=96.702489
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=t7qHR8yvU2Xs4M5dW9zLzhzc2x1ufZ2NBbeFoXyWRPerNsIh77c0Z8qbJTMYQNFGPicSr8Zc2PLZF4BzoqlaU5RQtzON0x2qySrUGvtudKv86KtiZSSSFM4PnqbxOBndatb5YEyTYRiNvTWqraV93TE0yhORM%2BQKkjT9%2FZY4x6OaiasEjHWETl%2BBsZ0qIBB8C3ucI8p%2FlrO50Ei2cuJ%2BghY7qKuknNBC2drYYkcWgRgSPwhklJq%2FfWo0OlyvDrUDJ2FTlDBQosg8xmomlVVIoA%3D%3D--6tJROZjd5WV8yS0f--1JM%2FYiIOq8ClejragAnHng%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.341545429.1766802313; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 02:25:13 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 27 Dec 2026 02:25:13 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E5EC:3654E1:3E4BC0C:4AF29FD:694F4389
WaylandBackend: fix crash when switching TTYs by Ferdi265 · Pull Request #1919 · ValveSoftware/gamescope · GitHub
Ferdi265
force-pushed
the
fix-null-wl-pointer-crash
branch
from
July 14, 2025 20:43
Copy link
Copy link
Ferdi265
force-pushed
the
fix-null-wl-pointer-crash
branch
from
August 7, 2025 21:40
Ferdi265
force-pushed
the
fix-null-wl-pointer-crash
branch
from
September 23, 2025 21:57
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
forked from ValveSoftware/steamos-compositor
-
Notifications
You must be signed in to change notification settings - Fork 304
WaylandBackend: fix crash when switching TTYs #1919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
emersion
merged 1 commit into
ValveSoftware:master
from
Ferdi265:fix-null-wl-pointer-crash
Oct 4, 2025
Merged
WaylandBackend: fix crash when switching TTYs #1919
emersion
merged 1 commit into
ValveSoftware:master
from
Ferdi265:fix-null-wl-pointer-crash
Oct 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferdi265
force-pushed
the
fix-null-wl-pointer-crash
branch
from
ab24255 to
52ed746
Compare
Author
|
improved the commit message by mentioning the function where the crash occurs. |
Author
|
@misyltoad / @lostgoat, could someone of you take a look at this? It's a ~1line change (a single early return / null ptr check) and does not have any impact on use when not switching TTYs. |
Ferdi265
force-pushed
the
fix-null-wl-pointer-crash
branch
from
52ed746 to
a28ca7a
Compare
This can happen when the seat loses pointer capability, such as when switching to another TTY on Sway.
Ferdi265
force-pushed
the
fix-null-wl-pointer-crash
branch
from
a28ca7a to
7c072d7
Compare
Author
|
rebased onto latest master |
emersion
approved these changes
Oct 4, 2025
Collaborator
emersion
left a comment
emersion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR fixes a crash in
UpdateCursor()that occurs when switching TTYs due to m_pPointer (awl_pointer*) being null.This can happen when the seat loses pointer capability, such as when switching to another TTY on Sway.
The fix is just to ignore the cursor update with an early return when there is no
wl_pointer, same asSetRelativeMouseMode()already does.This PR makes it possible to use screen lockers that switch TTY or use multiple sessions on different TTYs while gamescope is active without the whole gamescope session crashing.
Fixes #1920.