@maralorn In general we don't modify the hackage-packages.nix file manually, but wait for the automatic daily update thing to run. (Which is slightly annoying, because it is hard to test that the PR will actually work.)

Could you remove the changes to hackage-packages.nix from this PR?

Once you do that, I'll merge this in.

@cdepillabout Last friday @peti said, that he is totally open for others to also run the hackage-packages.nix update. So I thought this is fine.

I saw him rebasing all updates together before merging into master so maybe I should do it into it's own commit with the standard commit-message that ./update-nixpkgs.sh generates?

I think doing PRs like this is better for testing. But we can stick with the other way if that‘s preferred.

EDIT: Anyways I removed it, because I prefer this PR to be merged quickly.

@maralorn Ah, okay, if @peti is okay with it, then it works for me!

I'll let him comment here before I merge it though.

edit: Oh, I see that you removed the change. I'll go ahead and merge it in then.

In general we don't modify the hackage-packages.nix file manually, but wait for the automatic daily update thing to run.

I believe that no harm can come from people submitting changes to hackage-packages.nix that were generated by running hackage2nix properly. Those changes should not cause any merge conflicts when the generator commits the next update since it generates the exact same change. What we don't is people committing random manual changes to the file, obviously, but changes that come from hackage2nix should be safe.

@peti That makes sense.

In the future, I'll be sure to merge PRs even if they contain changes to hackage-packages.nix, as long as those changes have been generated by hackage2nix properly.