| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 30 Dec 2025 11:34:44 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=428.05845,conversation_content-fragment;desc="conversation_content fragment";dur=1184.192378,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=375.275552,nginx;desc="NGINX";dur=1.118865,glb;desc="GLB";dur=95.979824
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=SFgg7%2BMW%2Fq6iDNXO7oDreQ148UHbxGy3zPNLDoOlZQMCOTIqmTlv4VL0sGz47KVvRoH7Mf1NxGMXKQqrdTV3IpOdVJEAKR0d1DHrPVttpOWmZr%2Bx0iiajQ0jSeu9Dhom%2F29CIuORlHPp2VThcp23XArquAC195no%2FB4EDQjekCW2ZwxOlnN2ESYUT28xJ%2B1AnYBAasEtNUDZYytbI%2BZDYdbktT3jFQDeJwNQv9dgmcvRbkyeHoTnbb%2FOnN9rrP8O3NF3gGtPe%2BVEMx59mc3VAg%3D%3D--LiQ8e7%2F4i0fy7KxD--1WFbwweaEU857Wlc9oUzaw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1160796757.1767094483; Path=/; Domain=github.com; Expires=Wed, 30 Dec 2026 11:34:43 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 30 Dec 2026 11:34:43 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9324:1D35DB:891BFD:95C87D:6953B8D3
Python script editor should provide a workspace ID when updating model by Dewb · Pull Request #9988 · DynamoDS/Dynamo · GitHub
Copy link
Dewb
changed the title
Python node should provide a workspace ID when updating model
Python script editor should provide a workspace ID when updating model
Sep 18, 2019
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 667
Python script editor should provide a workspace ID when updating model #9988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Need to add a test for #9479 and confirm that the API change to add a parameter to the internal method |
Dewb
changed the title
| } | ||
|
|
||
| internal void Initialize(Guid nodeGuid, string propName, string propValue) | ||
| internal void Initialize(Guid workspaceGuid, Guid nodeGuid, string propName, string propValue) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be fine as it's an internal method.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire class probably ought to be internal instead of public, as it's not useful without being able to call the Initialize method.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dewb In this case, can you make a comment to the class, e.g. TODO: Make this class internal in Dynamo 3.0? By the time we tackle it, we would remember to do this.
Member
|
@Dewb this seems like a good crash fix, do need help finishing up the tests so that it might make it into 2.5? |
Contributor
Author
|
Tests are still blocked by the undo bug. Let's talk tomorrow about a strategy to get these both resolved. |
Member
|
tracked with https://jira.autodesk.com/browse/DYN-2155 |
Contributor
Author
|
I believe this is ready to merge. |
Member
|
@Dewb thanks! this looks good to me, we can take cherry picking this to 2.5 RC branch. |
mjkkirschner
pushed a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Nov 26, 2019
DynamoDS#9988) * Python node should provide a workspace ID when calling UpdateModelValueCommand, fixing DynamoDS#9479 * Draft test for DynamoDS#9479 (not passing yet due to undo issues) * Disable section of python custom node save test that uses undo * Remove file added by accident * Fix null dereference in UpdateModelValueImpl (cherry picked from commit e775794)
mjkkirschner
added a commit
that referenced
this pull request
Nov 26, 2019
#9988) (#10173) * Python node should provide a workspace ID when calling UpdateModelValueCommand, fixing #9479 * Draft test for #9479 (not passing yet due to undo issues) * Disable section of python custom node save test that uses undo * Remove file added by accident * Fix null dereference in UpdateModelValueImpl (cherry picked from commit e775794)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
The Python node's code editor sends an UpdateModelValueCommand with an empty workspace GUID, meaning the current workspace. Since the Python editor is no longer modal, this assumption (that the parent workspace is current) no longer holds. This change explicitly provides the workspace ID. This fixes #9479, avoiding a crash when a modeless Python node editor is opened from a custom node workspace and "Run" or "Save" is clicked while the home workspace is current.
Declarations
Check these if you believe they are true
*.resxfiles