| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 29 Dec 2025 23:28:25 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=419.447727,conversation_content-fragment;desc="conversation_content fragment";dur=1465.187975,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=415.97233,nginx;desc="NGINX";dur=0.524963,glb;desc="GLB";dur=96.413024
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=x35KZ7Pb52wcKXk6RA2nroaAognTm%2F%2FX%2BXYszaxxY%2F8bogknrYiG2u9smyJZq4lzbAOMuhre39O%2BYJUvY8ghQmWs4DoDdq1lYsaVrNzKCOMhG3vYDRGKjNGVnlGv08zCOI%2BGzh856qEfJZe%2F7ZiEPd6hjt1pAZtqismW7zxpTjnNBJWXxbCbh24HGLiR5OCprQuz%2B1TTRrSwCz4jZOwxZJhwpBs4ETO9loVX%2Fx3WJsewMEbAk82EJ%2FQVaDunfdxN3La059W4r3wht3xJXL5W6w%3D%3D--gcZ6BlrVqvrca73K--UA25Sjz77zjrQXR7yN6cQg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.324727696.1767050904; Path=/; Domain=github.com; Expires=Tue, 29 Dec 2026 23:28:24 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 29 Dec 2026 23:28:24 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DF0E:3654E1:689AB7D:7D48D0E:69530E98
DYN-9680 Crash Missing Dynamo folder by RobertGlobant20 · Pull Request #16633 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Copy link
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 666
DYN-9680 Crash Missing Dynamo folder #16633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 2 commits into
DynamoDS:master
from
RobertGlobant20:DYN-9680-Crash-Missing-DynamoFolder
Oct 23, 2025
Merged
DYN-9680 Crash Missing Dynamo folder #16633
QilongTang
merged 2 commits into
DynamoDS:master
from
RobertGlobant20:DYN-9680-Crash-Missing-DynamoFolder
Oct 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due that C:\ProgramData\Dynamo folder is not created any more then the code was expecting that folder to exist so Dynamo was crashing. I moved the code inside the try/catch and also added a validation that just execute the code if the directory exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9680
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a crash that occurs when the C:\ProgramData\Dynamo directory does not exist. The fix moves the directory access code inside the existing try-catch block and adds a validation check to ensure the directory exists before attempting to access it.
Key Changes
- Added directory existence validation before attempting to read XML files
- Moved the try-catch block to encompass the directory access logic
Comments suppressed due to low confidence (1)
src/DynamoCoreWpf/Views/SplashScreen/SplashScreen.xaml.cs:690
- There appears to be an extra closing brace at line 581. The try-catch block should close at line 580, but line 581 suggests an additional scope is being closed that isn't shown in the diff. Verify that the brace structure is correct in the full file context.
}
}
Contributor
Author
|
GIF showing that now is not crashing when C:\ProgramData\Dynamo folder is missing. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
QilongTang
approved these changes
Oct 23, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 90c42bb)
3 tasks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Dynamo crashing when C:\ProgramData\Dynamo doesn't exist.
Due that C:\ProgramData\Dynamo folder is not created any more then the code was expecting that folder to exist so Dynamo was crashing. I moved the code inside the try/catch and also added a validation that just execute the code if the directory exists.
Declarations
Check these if you believe they are true
Release Notes
Dynamo crashing when C:\ProgramData\Dynamo doesn't exist.
Reviewers
@QilongTang @zeusongit
FYIs
@jnealb